Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(7411): Resolve intrinsics elements by JSX namespaced tag names #53799

Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat(7411): Resolve intrinsics elements by JSX namespaced tag names #53799

merged 1 commit into from
Apr 17, 2023

Conversation

a-tarasyuk
Copy link
Contributor

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 16, 2023
@a-tarasyuk a-tarasyuk mentioned this pull request Apr 16, 2023
Closed
@DanielRosenwasser
Copy link
Member

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at a4159a6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at a4159a6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at a4159a6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at a4159a6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 16, 2023 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/152564/artifacts?artifactName=tgz&fileId=17FFE5CAFB801C146941722D97C1B2B099F34620DB40088633D4C655A01E8D2A02&fileName=/typescript-5.1.0-insiders.20230416.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53799-9".;

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/53799/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/53799/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53799

Metric main 53799 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 364,558k (± 0.01%) 364,611k (± 0.01%) +53k (+ 0.01%) 364,570k 364,645k p=0.013 n=6
Parse Time 3.54s (± 0.50%) 3.52s (± 0.43%) ~ 3.49s 3.53s p=0.140 n=6
Bind Time 1.19s (± 0.43%) 1.19s (± 0.63%) ~ 1.18s 1.20s p=0.784 n=6
Check Time 9.51s (± 0.33%) 9.50s (± 0.33%) ~ 9.45s 9.54s p=0.686 n=6
Emit Time 7.92s (± 0.46%) 7.89s (± 0.68%) ~ 7.84s 7.98s p=0.335 n=6
Total Time 22.15s (± 0.25%) 22.09s (± 0.27%) ~ 22.03s 22.18s p=0.196 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,580k (± 0.04%) 192,602k (± 0.03%) ~ 192,544k 192,663k p=0.521 n=6
Parse Time 1.58s (± 1.42%) 1.59s (± 0.40%) ~ 1.58s 1.60s p=0.787 n=6
Bind Time 0.82s (± 0.92%) 0.83s (± 0.62%) ~ 0.82s 0.83s p=0.247 n=6
Check Time 10.22s (± 0.66%) 10.34s (± 0.33%) +0.12s (+ 1.17%) 10.29s 10.38s p=0.008 n=6
Emit Time 2.97s (± 0.87%) 2.97s (± 1.03%) ~ 2.93s 3.00s p=1.000 n=6
Total Time 15.60s (± 0.40%) 15.72s (± 0.39%) +0.13s (+ 0.81%) 15.64s 15.80s p=0.013 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,758k (± 0.00%) 345,782k (± 0.02%) ~ 345,709k 345,881k p=0.810 n=6
Parse Time 2.72s (± 0.30%) 2.72s (± 0.64%) ~ 2.69s 2.74s p=1.000 n=6
Bind Time 1.09s (± 0.37%) 1.08s (± 0.70%) -0.01s (- 0.92%) 1.07s 1.09s p=0.029 n=6
Check Time 7.84s (± 0.32%) 7.80s (± 0.31%) -0.04s (- 0.53%) 7.76s 7.82s p=0.029 n=6
Emit Time 4.44s (± 0.68%) 4.41s (± 0.88%) ~ 4.36s 4.47s p=0.296 n=6
Total Time 16.08s (± 0.37%) 16.01s (± 0.24%) ~ 15.95s 16.07s p=0.064 n=6
TFS - node (v16.17.1, x64)
Memory used 300,054k (± 0.01%) 300,066k (± 0.01%) ~ 300,048k 300,095k p=0.689 n=6
Parse Time 2.15s (± 0.42%) 2.15s (± 0.62%) ~ 2.14s 2.17s p=0.666 n=6
Bind Time 1.24s (± 0.79%) 1.25s (± 0.94%) ~ 1.23s 1.26s p=0.314 n=6
Check Time 7.20s (± 0.43%) 7.17s (± 0.24%) -0.03s (- 0.46%) 7.15s 7.20s p=0.041 n=6
Emit Time 4.34s (± 0.76%) 4.36s (± 0.94%) ~ 4.31s 4.41s p=0.624 n=6
Total Time 14.93s (± 0.26%) 14.92s (± 0.32%) ~ 14.85s 14.97s p=0.936 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,148k (± 0.01%) 481,093k (± 0.01%) ~ 481,074k 481,142k p=0.128 n=6
Parse Time 3.23s (± 0.26%) 3.25s (± 0.36%) +0.02s (+ 0.52%) 3.24s 3.27s p=0.021 n=6
Bind Time 0.95s (± 0.54%) 0.95s (± 0.79%) ~ 0.94s 0.96s p=0.241 n=6
Check Time 17.81s (± 0.28%) 17.76s (± 0.29%) ~ 17.71s 17.85s p=0.125 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.99s (± 0.25%) 21.96s (± 0.20%) ~ 21.92s 22.04s p=0.421 n=6
xstate - node (v16.17.1, x64)
Memory used 559,360k (± 0.03%) 559,332k (± 0.01%) ~ 559,268k 559,455k p=0.689 n=6
Parse Time 3.98s (± 0.38%) 3.99s (± 0.37%) ~ 3.97s 4.01s p=0.570 n=6
Bind Time 1.75s (± 0.48%) 1.78s (± 0.59%) +0.03s (+ 1.72%) 1.76s 1.79s p=0.005 n=6
Check Time 3.02s (± 0.57%) 3.04s (± 0.71%) ~ 3.01s 3.07s p=0.064 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.84s (± 0.30%) 8.90s (± 0.17%) +0.06s (+ 0.66%) 8.88s 8.91s p=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53799 6
Baseline main 6

Developer Information:

Download Benchmark

@DanielRosenwasser DanielRosenwasser marked this pull request as ready for review April 17, 2023 00:19
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@DanielRosenwasser DanielRosenwasser merged commit 378ffa4 into microsoft:main Apr 17, 2023
@DanielRosenwasser
Copy link
Member

We'll get the tests in a follow-up

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/53799/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/53799/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

⚠️ Note that built had errors ⚠️ 
Exited unexpectedly with signal SIGABRT


Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

 
{"seq":1372,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/cli/src/commands/fix.ts","projectRootPath":"@PROJECT_ROOT@"}]}}
{"seq":1373,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/packages/cli/src/commands/fix.ts"}},"skipDestructiveCodeActions":true}}
{"seq":1374,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/packages/cli/src/commands/fix.ts"}}
{"seq":1375,"type":"request","command":"navto","arguments":{"searchValue":"a","maxResultCount":256}}

Repro Steps
  1. git clone https://github.com/backstage/backstage --recurse-submodules
  2. In dir backstage, run git reset --hard 54f741d1f0229f0b7026f485d48307a8cb33ba8f
  3. Install packages (exact steps are below, but it might be easier to follow the repo readme)
    1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
    2. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
    3. In dir backstage, run yarn install --no-immutable --mode=skip-build
    4. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
  4. Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

@a-tarasyuk a-tarasyuk mentioned this pull request Apr 17, 2023
Merged
@eps1lon eps1lon mentioned this pull request Apr 17, 2023
Merged
7 tasks
@kylpo kylpo mentioned this pull request Apr 22, 2023
Open
@weswigham weswigham mentioned this pull request May 2, 2023
Merged
@Andarist Andarist mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot