JSX namespace names should not be considered expressions

[weswigham]

Fixes the regression in this comment, which was regressed by #47356 (and followup #53799), which mistakenly classified JsxNamespacedName nodes as Expressions, which masked a ton of locations where they were effectively unhandled - the relevant location in the case of the regression being getLiteralTypeFromPropertyName, which started returning errorType for all jsx namespace names (which perviously were correctly the a:b string, thanks to the funky identifier we used to use).

As an aside, checkExpressionWorker currently silently returns errorType for all unknown expression types - shouldn't this be a hard Debug.fail calling out the unhandled case? This may have been more obvious had that been the case.

[weswigham]

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at b22a671. You can monitor the build here.

[typescript-bot]

Heya @weswigham, I've started to run the perf test suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

[DanielRosenwasser]

As an aside, checkExpressionWorker currently silently returns errorType for all unknown expression types - shouldn't this be a hard Debug.fail calling out the unhandled case? This may have been more obvious had that been the case.

Good point - let's try that out in a follow-up PR on the top 100.

[DanielRosenwasser]

Looks good but get another review.

Also, might be good to have a test with an index signature like `ns:do-${string}`

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54104

Metric	main	54104	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	365,868k (± 0.00%)	365,806k (± 0.01%)	-62k (- 0.02%)	365,762k	365,833k	p=0.005 n=6
Parse Time	3.40s (± 0.85%)	3.41s (± 0.97%)	~	3.37s	3.47s	p=0.933 n=6
Bind Time	1.10s (± 0.94%)	1.11s (± 0.73%)	~	1.10s	1.12s	p=0.112 n=6
Check Time	8.74s (± 0.48%)	8.74s (± 0.41%)	~	8.70s	8.79s	p=0.744 n=6
Emit Time	7.42s (± 0.18%)	7.44s (± 0.88%)	~	7.37s	7.52s	p=1.000 n=6
Total Time	20.65s (± 0.28%)	20.69s (± 0.28%)	~	20.63s	20.76s	p=0.376 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	190,969k (± 0.01%)	191,876k (± 1.21%)	~	190,912k	196,618k	p=0.173 n=6
Parse Time	1.49s (± 0.27%)	1.50s (± 0.50%)	+0.01s (+ 0.67%)	1.49s	1.51s	p=0.029 n=6
Bind Time	0.77s (± 0.53%)	0.78s (± 0.66%)	~	0.77s	0.78s	p=0.112 n=6
Check Time	9.60s (± 0.46%)	9.68s (± 1.06%)	~	9.55s	9.81s	p=0.077 n=6
Emit Time	2.75s (± 0.96%)	2.78s (± 1.46%)	~	2.75s	2.86s	p=0.324 n=6
Total Time	14.61s (± 0.36%)	14.74s (± 0.81%)	+0.13s (+ 0.90%)	14.57s	14.87s	p=0.045 n=6
Monaco - node (v18.10.0, x64)
Memory used	346,562k (± 0.01%)	346,568k (± 0.00%)	~	346,550k	346,582k	p=0.471 n=6
Parse Time	2.57s (± 0.84%)	2.60s (± 0.63%)	+0.03s (+ 1.17%)	2.59s	2.63s	p=0.034 n=6
Bind Time	1.00s (± 0.75%)	1.01s (± 0.75%)	~	1.00s	1.02s	p=0.062 n=6
Check Time	7.16s (± 0.32%)	7.16s (± 0.37%)	~	7.13s	7.20s	p=0.936 n=6
Emit Time	4.22s (± 0.57%)	4.25s (± 0.96%)	~	4.20s	4.30s	p=0.374 n=6
Total Time	14.96s (± 0.18%)	15.02s (± 0.34%)	~	14.96s	15.08s	p=0.065 n=6
TFS - node (v18.10.0, x64)
Memory used	300,751k (± 0.01%)	300,769k (± 0.01%)	~	300,735k	300,793k	p=0.297 n=6
Parse Time	2.05s (± 0.60%)	2.07s (± 0.94%)	~	2.04s	2.09s	p=0.216 n=6
Bind Time	1.14s (± 0.00%)	1.14s (± 0.86%)	~	1.13s	1.15s	p=0.652 n=6
Check Time	6.63s (± 0.43%)	6.61s (± 0.26%)	~	6.59s	6.63s	p=0.164 n=6
Emit Time	3.88s (± 0.45%)	3.86s (± 0.45%)	~	3.84s	3.89s	p=0.073 n=6
Total Time	13.71s (± 0.27%)	13.68s (± 0.22%)	~	13.64s	13.71s	p=0.293 n=6
material-ui - node (v18.10.0, x64)
Memory used	482,306k (± 0.01%)	481,649k (± 0.01%)	-657k (- 0.14%)	481,612k	481,699k	p=0.005 n=6
Parse Time	3.08s (± 0.48%)	3.09s (± 0.39%)	~	3.07s	3.10s	p=0.325 n=6
Bind Time	0.91s (± 0.60%)	0.91s (± 1.13%)	~	0.90s	0.93s	p=0.138 n=6
Check Time	16.78s (± 0.19%)	16.80s (± 0.35%)	~	16.74s	16.89s	p=1.000 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	20.77s (± 0.13%)	20.80s (± 0.28%)	~	20.74s	20.88s	p=0.571 n=6
xstate - node (v18.10.0, x64)
Memory used	562,865k (± 0.02%)	562,780k (± 0.02%)	~	562,637k	562,897k	p=0.230 n=6
Parse Time	3.82s (± 0.56%)	3.83s (± 0.69%)	~	3.79s	3.86s	p=0.257 n=6
Bind Time	1.63s (± 0.50%)	1.63s (± 0.60%)	~	1.61s	1.64s	p=0.546 n=6
Check Time	2.80s (± 0.37%)	2.81s (± 0.82%)	~	2.79s	2.85s	p=0.806 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	8.33s (± 0.42%)	8.36s (± 0.59%)	~	8.28s	8.42s	p=0.515 n=6
Angular - node (v16.17.1, x64)
Memory used	365,271k (± 0.01%)	365,158k (± 0.00%)	-113k (- 0.03%)	365,145k	365,170k	p=0.005 n=6
Parse Time	3.55s (± 0.45%)	3.57s (± 0.49%)	~	3.54s	3.59s	p=0.195 n=6
Bind Time	1.17s (± 0.44%)	1.18s (± 0.46%)	+0.01s (+ 0.99%)	1.18s	1.19s	p=0.013 n=6
Check Time	9.56s (± 0.42%)	9.61s (± 0.44%)	~	9.53s	9.66s	p=0.075 n=6
Emit Time	7.95s (± 0.47%)	7.88s (± 0.64%)	-0.06s (- 0.78%)	7.84s	7.98s	p=0.044 n=6
Total Time	22.23s (± 0.32%)	22.24s (± 0.34%)	~	22.13s	22.33s	p=0.809 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,758k (± 0.05%)	192,694k (± 0.05%)	~	192,621k	192,818k	p=0.230 n=6
Parse Time	1.59s (± 0.62%)	1.58s (± 1.63%)	~	1.54s	1.61s	p=1.000 n=6
Bind Time	0.82s (± 1.09%)	0.82s (± 0.66%)	~	0.82s	0.83s	p=0.341 n=6
Check Time	10.28s (± 0.30%)	10.32s (± 0.39%)	~	10.26s	10.36s	p=0.077 n=6
Emit Time	3.01s (± 0.89%)	3.00s (± 1.26%)	~	2.97s	3.07s	p=0.625 n=6
Total Time	15.69s (± 0.23%)	15.73s (± 0.37%)	~	15.66s	15.79s	p=0.378 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,850k (± 0.00%)	345,850k (± 0.01%)	~	345,818k	345,887k	p=0.936 n=6
Parse Time	2.70s (± 0.19%)	2.73s (± 0.43%)	+0.02s (+ 0.92%)	2.72s	2.75s	p=0.004 n=6
Bind Time	1.08s (± 0.95%)	1.08s (± 0.70%)	~	1.07s	1.09s	p=0.931 n=6
Check Time	7.85s (± 0.42%)	7.86s (± 0.53%)	~	7.83s	7.94s	p=0.809 n=6
Emit Time	4.46s (± 0.66%)	4.47s (± 0.66%)	~	4.42s	4.51s	p=0.686 n=6
Total Time	16.10s (± 0.30%)	16.14s (± 0.40%)	~	16.07s	16.23s	p=0.199 n=6
TFS - node (v16.17.1, x64)
Memory used	300,101k (± 0.00%)	300,112k (± 0.01%)	~	300,084k	300,144k	p=0.295 n=6
Parse Time	2.14s (± 0.35%)	2.16s (± 1.05%)	+0.02s (+ 1.01%)	2.14s	2.20s	p=0.046 n=6
Bind Time	1.23s (± 1.08%)	1.24s (± 1.19%)	~	1.22s	1.26s	p=0.458 n=6
Check Time	7.25s (± 0.38%)	7.28s (± 0.51%)	~	7.22s	7.32s	p=0.147 n=6
Emit Time	4.36s (± 0.69%)	4.32s (± 0.32%)	-0.04s (- 0.99%)	4.30s	4.34s	p=0.029 n=6
Total Time	14.98s (± 0.35%)	14.99s (± 0.40%)	~	14.89s	15.07s	p=0.573 n=6
material-ui - node (v16.17.1, x64)
Memory used	481,596k (± 0.01%)	480,890k (± 0.00%)	-706k (- 0.15%)	480,858k	480,907k	p=0.005 n=6
Parse Time	3.22s (± 0.38%)	3.25s (± 0.49%)	+0.02s (+ 0.78%)	3.23s	3.27s	p=0.021 n=6
Bind Time	0.93s (± 0.44%)	0.94s (± 1.04%)	+0.01s (+ 1.07%)	0.93s	0.96s	p=0.033 n=6
Check Time	17.83s (± 0.45%)	17.84s (± 0.78%)	~	17.61s	18.00s	p=0.748 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.98s (± 0.37%)	22.03s (± 0.72%)	~	21.78s	22.22s	p=0.521 n=6
xstate - node (v16.17.1, x64)
Memory used	560,325k (± 0.02%)	560,439k (± 0.02%)	~	560,267k	560,579k	p=0.173 n=6
Parse Time	3.97s (± 0.21%)	4.01s (± 0.40%)	+0.03s (+ 0.84%)	3.98s	4.02s	p=0.008 n=6
Bind Time	1.76s (± 0.59%)	1.77s (± 0.42%)	~	1.76s	1.78s	p=0.155 n=6
Check Time	3.06s (± 0.87%)	3.07s (± 0.70%)	~	3.05s	3.11s	p=0.226 n=6
Emit Time	0.09s (± 4.62%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=0.405 n=6
Total Time	8.88s (± 0.38%)	8.94s (± 0.40%)	+0.06s (+ 0.66%)	8.88s	8.99s	p=0.025 n=6
Angular - node (v14.21.3, x64)
Memory used	359,297k (± 0.01%)	359,179k (± 0.01%)	-118k (- 0.03%)	359,143k	359,219k	p=0.005 n=6
Parse Time	3.65s (± 0.62%)	3.69s (± 0.70%)	+0.04s (+ 1.10%)	3.65s	3.71s	p=0.029 n=6
Bind Time	1.21s (± 0.74%)	1.22s (± 0.33%)	~	1.21s	1.22s	p=0.086 n=6
Check Time	9.96s (± 0.46%)	9.97s (± 0.31%)	~	9.95s	10.03s	p=0.746 n=6
Emit Time	8.25s (± 0.47%)	8.28s (± 0.45%)	~	8.24s	8.32s	p=0.408 n=6
Total Time	23.07s (± 0.22%)	23.15s (± 0.21%)	+0.08s (+ 0.33%)	23.07s	23.20s	p=0.045 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used	188,089k (± 0.01%)	188,019k (± 0.01%)	-70k (- 0.04%)	187,979k	188,066k	p=0.008 n=6
Parse Time	1.59s (± 0.86%)	1.61s (± 0.55%)	~	1.60s	1.62s	p=0.084 n=6
Bind Time	0.84s (± 0.48%)	0.85s (± 0.00%)	+0.01s (+ 0.99%)	0.85s	0.85s	p=0.007 n=6
Check Time	10.37s (± 0.79%)	10.46s (± 0.36%)	+0.10s (+ 0.93%)	10.39s	10.49s	p=0.016 n=6
Emit Time	3.14s (± 0.69%)	3.13s (± 0.69%)	~	3.10s	3.16s	p=0.226 n=6
Total Time	15.95s (± 0.54%)	16.05s (± 0.24%)	+0.10s (+ 0.63%)	15.98s	16.09s	p=0.030 n=6
Monaco - node (v14.21.3, x64)
Memory used	340,959k (± 0.01%)	340,963k (± 0.01%)	~	340,947k	340,996k	p=0.936 n=6
Parse Time	2.80s (± 0.80%)	2.80s (± 0.47%)	~	2.78s	2.81s	p=0.797 n=6
Bind Time	1.11s (± 1.19%)	1.11s (± 0.80%)	~	1.10s	1.12s	p=0.932 n=6
Check Time	8.15s (± 0.26%)	8.17s (± 0.55%)	~	8.13s	8.25s	p=0.421 n=6
Emit Time	4.70s (± 0.86%)	4.67s (± 0.57%)	~	4.65s	4.72s	p=0.290 n=6
Total Time	16.76s (± 0.36%)	16.76s (± 0.42%)	~	16.70s	16.88s	p=0.809 n=6
TFS - node (v14.21.3, x64)
Memory used	295,286k (± 0.00%)	295,289k (± 0.00%)	~	295,283k	295,298k	p=0.630 n=6
Parse Time	2.39s (± 0.57%)	2.39s (± 0.99%)	~	2.36s	2.42s	p=0.935 n=6
Bind Time	1.06s (± 0.00%)	1.07s (± 0.51%)	~	1.06s	1.07s	p=0.071 n=6
Check Time	7.58s (± 0.44%)	7.57s (± 0.42%)	~	7.54s	7.63s	p=0.809 n=6
Emit Time	4.34s (± 0.40%)	4.32s (± 0.68%)	~	4.28s	4.36s	p=0.168 n=6
Total Time	15.37s (± 0.37%)	15.34s (± 0.33%)	~	15.30s	15.43s	p=0.170 n=6
material-ui - node (v14.21.3, x64)
Memory used	477,182k (± 0.01%)	476,517k (± 0.01%)	-665k (- 0.14%)	476,475k	476,553k	p=0.005 n=6
Parse Time	3.32s (± 0.27%)	3.32s (± 0.65%)	~	3.30s	3.36s	p=0.198 n=6
Bind Time	1.00s (± 0.63%)	1.00s (± 0.75%)	~	0.99s	1.01s	p=0.718 n=6
Check Time	18.78s (± 0.46%)	18.73s (± 0.43%)	~	18.60s	18.80s	p=0.520 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.10s (± 0.35%)	23.05s (± 0.42%)	~	22.90s	23.17s	p=0.421 n=6
xstate - node (v14.21.3, x64)
Memory used	549,327k (± 0.00%)	549,323k (± 0.00%)	~	549,313k	549,343k	p=1.000 n=6
Parse Time	4.19s (± 0.51%)	4.23s (± 1.00%)	+0.04s (+ 0.95%)	4.20s	4.31s	p=0.043 n=6
Bind Time	1.65s (± 2.50%)	1.64s (± 4.06%)	~	1.54s	1.69s	p=0.459 n=6
Check Time	3.18s (± 0.86%)	3.17s (± 0.58%)	~	3.15s	3.20s	p=1.000 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	9.11s (± 0.71%)	9.13s (± 0.49%)	~	9.07s	9.19s	p=0.575 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.21.3, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.21.3, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.21.3, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.21.3, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.21.3, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.21.3, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.21.3, x64)

Benchmark	Name	Iterations
Current	54104	6
Baseline	main	6

TSServer

Comparison Report - main..54104

Metric	main	54104	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,528ms (± 0.40%)	2,545ms (± 0.88%)	~	2,520ms	2,583ms	p=0.199 n=6
Req 2 - geterr	5,705ms (± 0.44%)	5,681ms (± 1.81%)	~	5,481ms	5,771ms	p=1.000 n=6
Req 3 - references	341ms (± 0.39%)	337ms (± 0.52%)	-5ms (- 1.32%)	334ms	339ms	p=0.006 n=6
Req 4 - navto	283ms (± 1.24%)	286ms (± 0.95%)	+3ms (+ 1.00%)	283ms	291ms	p=0.040 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	85ms (± 1.05%)	84ms (± 5.60%)	~	74ms	86ms	p=0.932 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,642ms (± 0.41%)	2,654ms (± 0.69%)	~	2,620ms	2,672ms	p=0.128 n=6
Req 2 - geterr	4,336ms (± 0.29%)	4,353ms (± 0.58%)	~	4,314ms	4,375ms	p=0.173 n=6
Req 3 - references	349ms (± 0.94%)	352ms (± 1.20%)	~	349ms	360ms	p=0.167 n=6
Req 4 - navto	290ms (± 0.65%)	293ms (± 0.63%)	+4ms (+ 1.32%)	291ms	295ms	p=0.015 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	63ms (± 2.34%)	63ms (± 1.30%)	~	62ms	64ms	p=1.000 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,059ms (± 0.65%)	3,078ms (± 0.55%)	~	3,054ms	3,101ms	p=0.173 n=6
Req 2 - geterr	1,597ms (± 1.15%)	1,602ms (± 1.25%)	~	1,579ms	1,632ms	p=0.689 n=6
Req 3 - references	108ms (± 2.70%)	107ms (± 0.84%)	~	106ms	108ms	p=0.683 n=6
Req 4 - navto	362ms (± 0.23%)	365ms (± 0.50%)	+4ms (+ 0.97%)	362ms	367ms	p=0.010 n=6
Req 5 - completionInfo count	2,862 (± 0.00%)	2,862 (± 0.00%)	~	2,862	2,862	p=1.000 n=6
Req 5 - completionInfo	373ms (± 0.99%)	378ms (± 2.13%)	~	366ms	388ms	p=0.298 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,655ms (± 0.70%)	2,685ms (± 0.43%)	+30ms (+ 1.12%)	2,673ms	2,700ms	p=0.013 n=6
Req 2 - geterr	6,147ms (± 0.41%)	6,160ms (± 0.34%)	~	6,129ms	6,182ms	p=0.298 n=6
Req 3 - references	353ms (± 0.58%)	349ms (± 0.90%)	~	345ms	354ms	p=0.064 n=6
Req 4 - navto	283ms (± 0.27%)	286ms (± 0.38%)	+3ms (+ 1.00%)	285ms	287ms	p=0.004 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	85ms (± 7.50%)	85ms (± 6.97%)	~	81ms	93ms	p=0.562 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,809ms (± 0.49%)	2,839ms (± 1.04%)	~	2,791ms	2,871ms	p=0.092 n=6
Req 2 - geterr	4,703ms (± 0.39%)	4,718ms (± 0.49%)	~	4,679ms	4,750ms	p=0.230 n=6
Req 3 - references	363ms (± 0.54%)	364ms (± 0.59%)	~	361ms	367ms	p=0.418 n=6
Req 4 - navto	285ms (± 0.76%)	286ms (± 0.41%)	~	285ms	288ms	p=0.251 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	67ms (± 0.61%)	67ms (± 1.12%)	~	66ms	68ms	p=0.389 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,193ms (± 0.32%)	3,208ms (± 0.34%)	~	3,198ms	3,228ms	p=0.053 n=6
Req 2 - geterr	1,736ms (± 0.34%)	1,750ms (± 0.73%)	+14ms (+ 0.83%)	1,737ms	1,774ms	p=0.024 n=6
Req 3 - references	123ms (± 1.26%)	127ms (± 7.22%)	~	122ms	146ms	p=0.357 n=6
Req 4 - navto	341ms (± 1.26%)	344ms (± 0.66%)	~	341ms	347ms	p=0.172 n=6
Req 5 - completionInfo count	2,862 (± 0.00%)	2,862 (± 0.00%)	~	2,862	2,862	p=1.000 n=6
Req 5 - completionInfo	402ms (± 1.41%)	405ms (± 1.99%)	~	399ms	418ms	p=0.810 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen	2,779ms (± 0.65%)	2,790ms (± 0.63%)	~	2,764ms	2,813ms	p=0.297 n=6
Req 2 - geterr	6,332ms (± 0.68%)	6,337ms (± 0.83%)	~	6,243ms	6,375ms	p=0.936 n=6
Req 3 - references	368ms (± 0.84%)	362ms (± 1.51%)	~	354ms	369ms	p=0.092 n=6
Req 4 - navto	291ms (± 0.84%)	294ms (± 0.73%)	+4ms (+ 1.26%)	292ms	298ms	p=0.036 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	99ms (± 5.66%)	96ms (± 7.92%)	~	85ms	104ms	p=0.517 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen	2,953ms (± 0.50%)	2,982ms (± 0.40%)	+28ms (+ 0.96%)	2,964ms	2,998ms	p=0.013 n=6
Req 2 - geterr	4,550ms (± 0.65%)	4,577ms (± 0.30%)	~	4,557ms	4,590ms	p=0.173 n=6
Req 3 - references	376ms (± 0.78%)	379ms (± 1.05%)	~	374ms	384ms	p=0.145 n=6
Req 4 - navto	297ms (± 0.27%)	301ms (± 0.54%)	+3ms (+ 1.12%)	298ms	302ms	p=0.008 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	77ms (± 0.98%)	77ms (± 0.67%)	~	76ms	77ms	p=0.784 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen	3,473ms (± 1.26%)	3,469ms (± 0.93%)	~	3,408ms	3,502ms	p=0.471 n=6
Req 2 - geterr	1,848ms (± 0.31%)	1,844ms (± 0.17%)	~	1,842ms	1,849ms	p=0.220 n=6
Req 3 - references	150ms (± 8.54%)	149ms (± 8.03%)	~	138ms	163ms	p=0.630 n=6
Req 4 - navto	394ms (± 1.66%)	396ms (± 1.53%)	~	388ms	402ms	p=0.686 n=6
Req 5 - completionInfo count	2,862 (± 0.00%)	2,862 (± 0.00%)	~	2,862	2,862	p=1.000 n=6
Req 5 - completionInfo	428ms (± 2.08%)	428ms (± 1.75%)	~	418ms	436ms	p=0.936 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.21.3, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.21.3, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.21.3, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.21.3, x64)

Benchmark	Name	Iterations
Current	54104	6
Baseline	main	6

Startup

Comparison Report - main..54104

Metric	main	54104	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	140.67ms (± 0.19%)	141.72ms (± 0.19%)	+1.06ms (+ 0.75%)	140.72ms	145.30ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	219.19ms (± 0.16%)	220.43ms (± 0.16%)	+1.24ms (+ 0.57%)	219.37ms	225.81ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	220.93ms (± 0.18%)	221.90ms (± 0.17%)	+0.97ms (+ 0.44%)	220.89ms	226.09ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	202.79ms (± 0.17%)	203.63ms (± 0.20%)	+0.85ms (+ 0.42%)	202.77ms	211.04ms	p=0.000 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	54104	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/54104/merge:

Everything looks good!

[typescript-bot]

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[andrewbranch]

Perf run almost looks like this is visible in parse time, but it’s pretty noisy, and the only real addition is a isJsxNamespacedName(initialExpression) call 🤔

[DanielRosenwasser]

@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at b22a671. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54104

Metric	main	54104	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	365,293k (± 0.01%)	365,173k (± 0.01%)	-121k (- 0.03%)	365,152k	365,233k	p=0.005 n=6
Parse Time	3.55s (± 0.55%)	3.57s (± 0.33%)	~	3.56s	3.59s	p=0.052 n=6
Bind Time	1.17s (± 0.54%)	1.17s (± 0.47%)	~	1.17s	1.18s	p=0.201 n=6
Check Time	9.53s (± 0.25%)	9.57s (± 0.57%)	~	9.51s	9.66s	p=0.229 n=6
Emit Time	7.89s (± 0.38%)	7.92s (± 0.84%)	~	7.83s	8.00s	p=0.575 n=6
Total Time	22.15s (± 0.19%)	22.25s (± 0.45%)	~	22.12s	22.41s	p=0.054 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,754k (± 0.03%)	192,708k (± 0.02%)	~	192,685k	192,759k	p=0.199 n=6
Parse Time	1.59s (± 0.95%)	1.60s (± 0.79%)	~	1.59s	1.62s	p=0.210 n=6
Bind Time	0.82s (± 0.00%)	0.83s (± 0.49%)	+0.01s (+ 1.02%)	0.82s	0.83s	p=0.007 n=6
Check Time	10.29s (± 0.63%)	10.34s (± 0.28%)	~	10.29s	10.36s	p=0.227 n=6
Emit Time	3.01s (± 0.84%)	3.01s (± 0.78%)	~	2.99s	3.05s	p=0.747 n=6
Total Time	15.71s (± 0.30%)	15.78s (± 0.16%)	+0.07s (+ 0.47%)	15.75s	15.81s	p=0.019 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,852k (± 0.01%)	345,853k (± 0.00%)	~	345,829k	345,864k	p=0.936 n=6
Parse Time	2.72s (± 0.61%)	2.73s (± 0.28%)	~	2.72s	2.74s	p=0.367 n=6
Bind Time	1.09s (± 0.75%)	1.09s (± 0.50%)	~	1.08s	1.09s	p=0.859 n=6
Check Time	7.85s (± 0.33%)	7.88s (± 0.58%)	~	7.82s	7.94s	p=0.333 n=6
Emit Time	4.47s (± 0.80%)	4.51s (± 0.88%)	~	4.47s	4.57s	p=0.227 n=6
Total Time	16.13s (± 0.31%)	16.20s (± 0.49%)	~	16.09s	16.30s	p=0.127 n=6
TFS - node (v16.17.1, x64)
Memory used	300,115k (± 0.01%)	300,111k (± 0.01%)	~	300,075k	300,145k	p=0.873 n=6
Parse Time	2.14s (± 0.35%)	2.15s (± 0.56%)	~	2.13s	2.16s	p=0.502 n=6
Bind Time	1.24s (± 1.10%)	1.24s (± 1.66%)	~	1.22s	1.28s	p=0.622 n=6
Check Time	7.27s (± 0.51%)	7.28s (± 0.59%)	~	7.24s	7.35s	p=0.872 n=6
Emit Time	4.38s (± 0.51%)	4.29s (± 0.70%)	-0.09s (- 2.06%)	4.25s	4.32s	p=0.005 n=6
Total Time	15.02s (± 0.40%)	14.95s (± 0.46%)	~	14.88s	15.06s	p=0.109 n=6
material-ui - node (v16.17.1, x64)
Memory used	481,621k (± 0.02%)	480,897k (± 0.01%)	-724k (- 0.15%)	480,841k	480,935k	p=0.005 n=6
Parse Time	3.23s (± 0.60%)	3.24s (± 0.57%)	~	3.22s	3.27s	p=0.327 n=6
Bind Time	0.93s (± 0.55%)	0.94s (± 0.00%)	+0.01s (+ 0.71%)	0.94s	0.94s	p=0.025 n=6
Check Time	17.83s (± 0.47%)	17.78s (± 0.40%)	~	17.72s	17.87s	p=0.260 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.99s (± 0.34%)	21.95s (± 0.32%)	~	21.90s	22.06s	p=0.377 n=6
xstate - node (v16.17.1, x64)
Memory used	560,357k (± 0.01%)	560,423k (± 0.02%)	~	560,284k	560,559k	p=0.230 n=6
Parse Time	3.97s (± 0.21%)	3.99s (± 0.19%)	+0.02s (+ 0.46%)	3.98s	4.00s	p=0.006 n=6
Bind Time	1.75s (± 0.31%)	1.77s (± 0.91%)	~	1.75s	1.79s	p=0.154 n=6
Check Time	3.05s (± 0.73%)	3.06s (± 1.06%)	~	3.02s	3.11s	p=0.686 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.88s (± 0.29%)	8.90s (± 0.51%)	~	8.84s	8.95s	p=0.422 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-148-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	54104	6
Baseline	main	6

Developer Information:

Download Benchmark