Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from corepack to a global npm install for now #54578

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

jakebailey
Copy link
Member

npm installed with corepack in some CI workflows is failing with a segfault. I have yet to see anyone else reporting this on node, npm, corepack, github actions, anywhere.

For now, just disable corepack and instead use an npm global install of the packageManager property. This property is a valid package name plus version so is a decent way to install a package manager of a particular version.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 8, 2023
@jakebailey jakebailey merged commit ee80068 into microsoft:main Jun 8, 2023
@jakebailey jakebailey deleted the drop-corepack branch June 8, 2023 18:12
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick to release-5.1

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 26, 2023

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.1 on this PR at 3ed5736. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #54787 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Jun 26, 2023
Component commits:
a104a54 Switch from corepack to a global npm install for now

3ed5736 Fix package-size
DanielRosenwasser pushed a commit that referenced this pull request Jun 26, 2023
…e-5.1 (#54787)

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants