Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable v8-compile-cache when using npm@>=9.7.0 #276

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 13, 2023

What's the problem this PR addresses?

Node.js segfaults when using npm@>=9.7.0 and v8-compile-cache

$ docker run -it node:20.3.0-slim corepack npm@9.7.1 --version
[SIGSEGV]

Seems the TypeScript team also noticed this issue, ref microsoft/TypeScript#54578 (cc @jakebailey).

Closes #277

How did you fix it?

Disabled the v8-compile-cache for npm@>=9.7.0 for now.

Node.js segfaults when using `npm@>=9.7.0` and `v8-compile-cache`
```console
$ docker run -it node:20.3.0-slim corepack npm@9.7.1 --version
[SIGSEGV]
```
@jakebailey
Copy link

Aha, a repro! Thanks for finding this.

@arcanis arcanis merged commit 2f3678c into nodejs:main Jun 13, 2023
@merceyz merceyz deleted the merceyz/fix/nodejs-npm-segfault branch June 13, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault: 11
3 participants