Mac: Don't download file sizes as part of OnEnumerateDirectory #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
|
No pipelines are associated with this pull request. |
|
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
|
No pipelines are associated with this pull request. |
kewillford
approved these changes
Jul 31, 2019
- Add comments where needed - Stop creating BlobSizeConnections in OnEnumerateDirectory - Remove populateSizes parameter from GetProjectedItems
|
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
|
No pipelines are associated with this pull request. |
|
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
|
No pipelines are associated with this pull request. |
|
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #699
As part of #1130 PrjFSLib was updated to stop filling placeholders with empty data. With that change, VFS4G on Mac no longer needs to download sizes when it writes placeholders.
With this optimization expanding the
srcfolder of a fresh clone in Finder was reduced from ~2min30sec to ~5sec on my MacBook.The same optimization can be made when VFS4G updates placeholders on Mac, and #1397 has been filed for that.