-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac: Don't download file sizes as part of OnEnumerateDirectory #1398
Mac: Don't download file sizes as part of OnEnumerateDirectory #1398
Conversation
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
No pipelines are associated with this pull request. |
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Gave a couple of suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
- Add comments where needed - Stop creating BlobSizeConnections in OnEnumerateDirectory - Remove populateSizes parameter from GetProjectedItems
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
No pipelines are associated with this pull request. |
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
No pipelines are associated with this pull request. |
/azp run GitHub VFSForGit Mac Large Repo Perf Tests |
No pipelines are associated with this pull request. |
Resolves #699
As part of #1130 PrjFSLib was updated to stop filling placeholders with empty data. With that change, VFS4G on Mac no longer needs to download sizes when it writes placeholders.
With this optimization expanding the
src
folder of a fresh clone in Finder was reduced from ~2min30sec to ~5sec on my MacBook.The same optimization can be made when VFS4G updates placeholders on Mac, and #1397 has been filed for that.