Merge milestones/M158 to releases/shipped #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, that local cache path defaults to `$HOME/.gvfsCache`, there's no need to specify --local-cache-path explicitly.
Native notifications can now have actions associated with them. When user clicks on the action button on a notification bubble, VFSForGit will run a Command in response. Example: Mount_Failure notification can specifiy the gvfs command "gvfs mount <path>" as its associated action. Actionable notifications also have an actionTitle, which get displayed as text in a Button control on the Notification bubble. Other details - Commands are run using Terminal app. - Terminal is launched using Applescript. - Only UpgradeAvailable and Mount_Failure notifications are actionable now. - VFSForGitNotification class now confirms to NSCoding protocol. VFSForGitNotification object holds details of the notification including associated commands. It is archived and sent to the OS notification center. When user clicks the notification bubble, the archived VFSForGitNotification is retrieved from the native notification, its associated Command is read and executed.
Initial cut of Health Feature
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
…sc.exe The [InnoSetup constants documentation](http://www.jrsoftware.org/ishelp/index.php?topic=consts) lists `{sys}` as the way to expand to what is typically `C:\Windows\System32`. This _should_ reduce issues with `PATH` modifications or system drive swaps. I manually tested upgrade to see that these paths were expanded correctly.
The git process was launched using a PATH environment variable with the gvfs hooks path to make sure that when a path in the repo was included in the user's PATH environment variable that it would only search outside the repo. This was when the code was using git cat-file to hydrate files and searching for gvfs hooks would cause it to hydrate files which would cause it to search for hooks and it would be in a loop. This is no longer the case, the code is using libgit2 and the hooks are not called. Since the gvfs hooks root was only used for setting the PATH for the git process, all references to it can be removed.
- Add comments where needed - Stop creating BlobSizeConnections in OnEnumerateDirectory - Remove populateSizes parameter from GetProjectedItems
Proper error message for 'git gui' on Mac
Currently the output for running functional tests put the service logs and the run times for each of the tests at the end after the actual test summary results. This makes finding the actual results of failures harder to find since you have to scroll up an indeterminate amount to get to the results. This change will move the test run summary to the bottom of the output. So you can go straight to the bottom to see any failures.
Increasing precision of timestamps being logged
…EnumerateDirectory Mac: Don't download file sizes as part of OnEnumerateDirectory
…t results at the end Add SetupFixture for teardown to get the test results at the end
…se sensitive volumes [Mac] Don't allow cloning or mounting on case sensitive volumes
Now, that local cache path defaults to $HOME/.gvfsCache, there's no need to specify --local-cache-path explicitly.
…UNDLE_VERSION. Additionally, make BUNDLE_VERSION Major.Minor
…FS logging daemon Mac: Add version information to kext and PrjFS logging daemon
…e use of gvfs hooks root No longer set PATH for git process and remove use of gvfs hooks root
Some organizational improvements to the code, since the SubDirectoryInfo object has named fields. Sub directory list now shows the fraction of files which are hydrated, sorting remains by number of hydrated files Added unit tests for the newly available information, the total number of files per sub directory.
Handle corrupt objects on Mac
…no-kext-user-version-validation Mac ProjFS: Don't perform user/kernel version validation for offline I/O
… headers in .cs files diff: use csharp driver for better function headers in .cs files
Dehydrate folders
- This fixes the failure when a Phython Executable is called before hydration.
Don't allow Executables to be Placeholders
Sparse ui cleanup
|
@jrbriggs @derrickstolee @jeschu1 should we hold this release for microsoft/git#186 (and #1455)? |
|
@wilbaker @jeschu1 @alameenshah no the release should be both platforms. |
@jrbriggs ok thanks! Any objects to porting #1517 to this branch (it has a fix for the background MIDX jobs causing out of memory exceptions)?
@jeschu1 how should PRs be tagged that are included in this release (or alternatively, how should PRs be tagged that will be in the next release)? |
I went ahead and created #1518 to merge in the fix for this release. @derrickstolee and @jeschu1 have signed off and I'll merge it in as soon as the tests complete. |
…-no-progress [Merge to M158] Call multi-pack-index with --no-progress
|
Please update description with list of PRs included, and possibly with the list of PRs in microsoft/git that were included. |
|
@wilbaker I believe @alameenshah is working on the perf number comparison |
jrbriggs
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
switchandrestore.List of PRs included
#1518 [Merge to M158] Call multi-pack-index with --no-progress
#1513 Sparse UI cleanup
#1498: Don't allow Executables to be Placeholder
#1506 from Mac installer preinstall failure
#1323 Dehydrate folders
#1508: diff: use csharp driver for better function headers in .cs files
#1499 from pmj/mac-projfs-offline-io-registration-no-kext-user-version-validation
#1507 Check the disposing flag in Dispose methods
#1466 from Better installer logs
#1486: Clean up Register/Unregister for OfflineIO
#1485: Mark panic strings as 'public' so they appear in Console
#1482 from pmj/mac-projfs-1479-1480-no-follow-symlinks
#1487: Use the full path to GVFS.Hooks executable in the hook configuration
#1483 from pmj/mac-projfs-shadowed-variable-bugfixes
#1412 from github/case-sensitive-repos
#1452: Correct Upgrade Messages for Mac
#1476 Mark MoveIndexFileFails as MacOnly because CmdRunner on Windows failing
#1473 Mac: Add mdworker_shared to the IsFileSystemCrawler block list
#1469 from Enabling Service verb Functional tests
#1389: Update Git to v2.23.0
#1467 Add a global setup class when using a --test= option
#1445: Check for new Panic Logs where PrjFSKextLogDaemon is started
#1289 from Actionable notifications
#1440: Add LogInfo / LogWarning messages to PrjFSLib
#1456 from Auto-unmount repos in pre-install
#1411 from github/backing-root-fixes
#1429 from pmj/mac-kext-182-block-offline-empty-file-access
#1428 from github/move-index-test
#1448 from github/use-dir-sep-char
#1450 Add information for when lock is release by process not owning the lock
#1446 Cleanup virtualizer tests
#1449 Don't log errors when MaintenanceSteps fail due to the repo being deleted
#1436: [Mac kext] Allow privileged system service 'amfid' to hydrate
#1337: [Mac Kext] Remove '/System/Volumes/Data' when only in path
#1408: Include panic logs for vfs in diagnose
#1431 Add lock around writes to SQLite database tables
#1409 from Halterer/SubDirectoryInfoObject
#1417: Update mac uninstall script to remove GVFS service directory
#1425: update NUnit dependencies
#1416 Mac: Fix and enable remaining dehydrate functional tests
#1421: Update Git, drop MIDX writes
#1208 from pmj/mac-kext-182-no-writes-on-offline-roots
#1280 from pmj/mac-kext-resize-roots
#1415: Update Git to include octopus merge bugfix
#1363: Handle corrupt objects on Mac
#1351 No longer set PATH for git process and remove use of gvfs hooks root
#1392 Mac: Add version information to kext and PrjFS logging daemon
#1308: Updating README.md
#1384: [Mac] Don't allow cloning or mounting on case sensitive volumes
#1399 Add SetupFixture for teardown to get the test results at the end
#1398 Mac: Don't download file sizes as part of OnEnumerateDirectory
#1394 Increasing precision of timestamps being logged
#1388: Proper error message for 'git gui' on Mac
#1393: Setup.iss: use {sys} variable when calling sc.exe
#1303: GVFS Health Feature