Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the full path to GVFS.Hooks executable in the hook configuration #1487

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Use the full path to GVFS.Hooks executable in the hook configuration #1487

merged 2 commits into from
Aug 24, 2019

Conversation

jrbriggs
Copy link
Member

Resolves #1481

@jrbriggs jrbriggs requested a review from wilbaker August 23, 2019 18:49
wilbaker
wilbaker approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@wilbaker wilbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestion for the unit tests

GVFS/GVFS.UnitTests/CommandLine/HooksInstallerTests.cs Outdated Show resolved Hide resolved
GVFS/GVFS.UnitTests/CommandLine/HooksInstallerTests.cs Outdated Show resolved Hide resolved
@jrbriggs jrbriggs merged commit 6446823 into microsoft:master Aug 24, 2019
@jrbriggs jrbriggs deleted the absolute-hook-path branch August 24, 2019 17:58
@jrbriggs jrbriggs added this to the M159 milestone Sep 12, 2019
@jeschu1 jeschu1 mentioned this pull request Sep 12, 2019
Merged
@derrickstolee derrickstolee mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilbaker wilbaker wilbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M159
Development

Successfully merging this pull request may close these issues.

Windows: Include the full path to GVFS.Hooks.exe in the pre/post command hook files
2 participants
@jrbriggs @wilbaker