[Linux] Convert tests and repair jobs to use backing root #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repair jobs run while the GVFS enlistment is not mounted, which on Linux requires us to use the backing root in order to access the .git contents.
chrisd8088
changed the title
This was referenced Aug 8, 2019
wilbaker
approved these changes
Aug 16, 2019
|
Hi @derrickstolee -- do you want to look this one over as well, or are you comfortable with my merging it into master now that @wilbaker signed off? Let me know either way, and many thanks! |
@chrisd8088 feel free to merge this PR in now, thanks! cc: @derrickstolee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all relevant uses of
RepoRootandWorkingDirectoryRootin the GVFS provider and functional tests to use the backing root, to ensure these tests will pass on systems where they are distinct (e.g., Linux).For example. repair jobs run while the GVFS enlistment is not mounted, which on Linux requires us to use the backing root in order to access the
.gitcontents; similarly, theMountTestsare adjusted to ensure they don't expect file contents within an unmounted repository./cc @jrbriggs, @kivikakk.