Auto-unmount repos in pre-install #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac installer pkg would now automatically unmount all repositories registered for auto mount Fixes #1124
|
/azp run PR - Mac - Build and Unit Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeschu1
reviewed
Aug 19, 2019
| if [ -f "${GVFSBINPATH}" ]; then | ||
| unmountCmd="${GVFSBINPATH} service --unmount-all" | ||
| echo $unmountCmd | ||
| eval $unmountCmd || exit 1 |
There was a problem hiding this comment.
Just to double check will the eval print any errors that come up from the call?
This follows the format of the other commands and lgtme.
jeschu1
approved these changes
Aug 19, 2019
wilbaker
reviewed
Aug 19, 2019
| @@ -34,7 +34,7 @@ | |||
|
|
|||
| function GetBlockingProcesses() | |||
There was a problem hiding this comment.
Does this get called before or after preinstall?
There was a problem hiding this comment.
Before preinstall.
This is the order - Distribution.xml::InstallationCheck, preinstall, postinstall.
derrickstolee
approved these changes
Aug 20, 2019
wilbaker
approved these changes
Aug 20, 2019
|
I think this will fail if you are running installer as root with a clean env (like using Munki or just sudo install) and should rather be: Same as the service restart commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac installer pkg would now automatically unmount all repositories registered for auto mount
Fixes #1124