-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-unmount repos in pre-install #1456
Conversation
Mac installer pkg would now automatically unmount all repositories registered for auto mount Fixes #1124
/azp run PR - Mac - Build and Unit Test |
Azure Pipelines successfully started running 1 pipeline(s). |
if [ -f "${GVFSBINPATH}" ]; then | ||
unmountCmd="${GVFSBINPATH} service --unmount-all" | ||
echo $unmountCmd | ||
eval $unmountCmd || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check will the eval print any errors that come up from the call?
This follows the format of the other commands and lgtme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it does.
@@ -34,7 +34,7 @@ | |||
|
|||
function GetBlockingProcesses() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get called before or after preinstall
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before preinstall
.
This is the order - Distribution.xml::InstallationCheck
, preinstall
, postinstall
.
I think this will fail if you are running installer as root with a clean env (like using Munki or just sudo install) and should rather be:
Same as the service restart commands. |
Mac installer pkg would now automatically unmount all repositories registered for auto mount
Fixes #1124