-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmount repositories prior to installation #74
Conversation
function GetBlockingProcesses() | ||
{ | ||
var watchList = [ "Scalar.Mount", "git", "gitk", "Wish" ]; | ||
var watchList = [ "git", "gitk", "Wish" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still want Scalar.Mount as a blocking process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would stop the installer from running, including the script that unmounts the running repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then does this same change need to be made in VFS for Git?
Just checked, no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done already, in microsoft/VFSForGit#1456.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change was just made in VFS4G in this PR: microsoft/VFSForGit#1456
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I installed this version locally, cloned (a new clone to get the service registry working), then reinstalled. Thanks!
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
resolves #60