Unmount repositories prior to installation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbriggs
suggested changes
Aug 20, 2019
| function GetBlockingProcesses() | ||
| { | ||
| var watchList = [ "Scalar.Mount", "git", "gitk", "Wish" ]; | ||
| var watchList = [ "git", "gitk", "Wish" ]; |
There was a problem hiding this comment.
Don't we still want Scalar.Mount as a blocking process?
There was a problem hiding this comment.
This would stop the installer from running, including the script that unmounts the running repos.
There was a problem hiding this comment.
Then does this same change need to be made in VFS for Git?
Just checked, no.
There was a problem hiding this comment.
Done already, in microsoft/VFSForGit#1456.
There was a problem hiding this comment.
That change was just made in VFS4G in this PR: microsoft/VFSForGit#1456
derrickstolee
approved these changes
Aug 20, 2019
jrbriggs
approved these changes
Aug 20, 2019
wilbaker
approved these changes
Aug 20, 2019
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jrbriggs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #60