Include panic logs for vfs in diagnose

[jeschu1]

resolves #1395

[pmj]

Some minor comments, beyond that this looks reasonable to me. However it's in code that's unfamiliar to me, so I'll leave approval to someone better versed in this code.

[pmj]

I think this will match any panics for which the ProjFS kext was loaded, not just those where it appeared in the stack trace. (There is a list of loaded kexts at the end of each panic log.) Is that the intended behaviour? Either way, it might be worth commenting on the intention of this check here.

[wilbaker]

Nice catch!

Is that the intended behaviour?

I think the intended behavior is to only include the panics where ProjFS kext appeared in the stack trace.

[jeschu1]

Looking at several panics it appears that if we're in the backtrace, we'll have the form org.vfsforgit.PrjFSKext(.

Would you advise that as the simplest way to do this?

[pmj]

We discussed this out-of-band and this does seem like the simplest solution.

[kewillford]

I'm wondering if we can remove the IKernelDriver.LogsFolderPath and IKernelDriver.TryFlushLogs and have one IKernelDriver.TryCopyLogs that will do the driver logs

// driver
if (this.FlushKernelDriverLogs())
{
	 string kernelLogsFolderPath = GVFSPlatform.Instance.KernelDriver.LogsFolderPath;

	// This copy sometimes fails because the OS has an exclusive lock on the etl files. The error is not actionable
	// for the user so we don't write the error message to stdout, just to our own log file.
	this.CopyAllFiles(Path.GetDirectoryName(kernelLogsFolderPath), archiveFolderPath, Path.GetFileName(kernelLogsFolderPath), copySubFolders: false, hideErrorsFromStdout: true);
}

plus the panic logs?

I'm not sure how much cleaner this would be or what you would need to pass to the method but I saw that we were already doing some GVFSPlatform.Instance specific things here and was wondering if this could fit in that same bucket or if it best to keep them separate.

[jeschu1]

I'm wondering if we can remove the IKernelDriver.LogsFolderPath and IKernelDriver.TryFlushLogs and have one IKernelDriver.TryCopyLogs that will do the driver logs plus the panic logs?

@kewillford an exellent point and something I certainly though about. TryFlushLogs has a different purpose and I think putting it all in one fuctions gives that function too much responsibility. What we have here is pretty explicit (and hopefully easy to understand! :-) )

[pmj]

Looks good to me now!