Mac ProjFS: shadowed variable bugfixes #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables were re-declared instead of simply assigned, potentially causing resource leaks and incorrect return codes on error control flow paths.
To avoid bugs resulting from shadowed variables in future, the corresponding compiler warning is now turned on across the entire project. A few benign instances discovered by the setting are resolved as well.
pmj
changed the title
wilbaker
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While scouring the PrjFSLib code for file I/O calls that might follow symlinks, I discovered that we were potentially leaking open directory handles and returning incorrect error codes in
HandleRecursivelyEnumerateDirectoryRequest()andRecursivelyMarkAllChildrenAsInRoot()due to erroneously re-declared/shadowed variables.The first commit fixes those errors.
The second commit turns on the compiler warning about shadowed variables. This uncovered a number of other instances of shadowed variables; fortunately these turned out to be largely benign, or in the case of the unit tests, pointed to unnecessary code. All the flagged instances are also fixed in this commit.