User/benkuhn/add vsix patch option #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 27, 2021 22:25
ghost
added
the
|
Note, this will be a situation of "review after commit" for logistical reasons, but @Scottj1s, I'd still greatly appreciate if you review this at your earliest convenience. |
BenJKuhn
added a commit
that referenced
this pull request
Apr 6, 2021
* adding VSIX version override support * formatting fix * non-empty default value * updating how versions are handled in build script * trying again * trying again * trying again * debugging * variable reference fix * simpler version Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com>
BenJKuhn
added a commit
that referenced
this pull request
Apr 13, 2021
* User/benkuhn/add vsix patch option (#654) * adding VSIX version override support * formatting fix * non-empty default value * updating how versions are handled in build script * trying again * trying again * trying again * debugging * variable reference fix * simpler version Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com> * minor tweak to versioning semantics. * simplifying VSIX build params since thin package versions are now locked together. Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com>
kythant
added a commit
that referenced
this pull request
Apr 23, 2021
Note from Will: May not actually include all these changes in the same form anymore. * Update framework udk (#511) * Cherry pick VSIX into 0.5 preview release branch (#517) * Update roadmap (unpackaged apps to 0.8) (#506) * Update roadmap (unpackaged apps to 0.8) * Include a subscribe option * Port VS changes in Microsoft.AppxPackage.targets to Microsoft.ApplicationModel.Resources.PriGen.targets: reduce messages printed to output to improve performance. (#485) * Initial checkin of Reunion VSIX, ported from WinUI3 (#496) * Initial checkin of Reunion VSIX, ported from WinUI VSIX sources * update nupkgs and fix wap appx references * added missing pubxml files * path bug, reunion tags * cruft, pubxml * remove Microsoft.WinUI.AppX.targets * remove asset dupes * PR feedback on appx manifests * replace nuget.config with RestoreSources to support pipeline, fix bad vstemplate * updated readmes * Initial checkin of Reunion VSIX, ported from WinUI3 (#496) * Initial checkin of Reunion VSIX, ported from WinUI VSIX sources * update nupkgs and fix wap appx references * added missing pubxml files * path bug, reunion tags * cruft, pubxml * remove Microsoft.WinUI.AppX.targets * remove asset dupes * PR feedback on appx manifests * replace nuget.config with RestoreSources to support pipeline, fix bad vstemplate * updated readmes Co-authored-by: Andrew Leader <aleader@microsoft.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com> * Tweaks for Reunion 0.5 Preview release (#524) (#525) * candidate versions of 0.5 preview nupkgs * update to latest nupkgs * another update and template fix * Cherry pick commit 8f2e841: Revert naming of win32 apps' PRI to the project name. (#529) * address build/restore issues causing vsix pipeline failures (#530) * Cherry pick: create VSIX pipeline (#509) (#537) * User/ertorres/create vsix (#509) * remove nuget org feed * remove vssdk overhead * always use internal feed (#547) * Search parent folder (#554) (#569) * simplify wap project templates to enable PackageReferences upgrades, ensure that ad hoc PackageReferences work for wapproj (#578) * Bump transport package version to 0.5 (#576) (#581) * GA tweaks - VS 16.9 prereq, WinUI 3 rename, remove UWP templates, Suspending event (#591) * GA tweaks - VS 16.9 prereq, WinUI 3 rename, UWP templates unsupported * remove UWP templates - not supported in release * remove experimental Suspending event * Update FrameworkUDK release (#614) * Remove unnecessary Pkg* defines and avoid bad vsix builds when nuget restore fails (still investigating those) (#631) * Duplicate MSBuildProjectExtensionsPath was causing inconsistent nuget restore and broken vsix builds (#640) * fixing regression from earlier VSIX MSbuild change that moved published file (#643) Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com> * drop preview tag (#646) Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com> * User/benkuhn/add vsix patch option (#654) * adding VSIX version override support * formatting fix * non-empty default value * updating how versions are handled in build script * trying again * trying again * trying again * debugging * variable reference fix * simpler version Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com> * Set SDKVersion (#674) (#684) * Move MrtCore up to cswinrt 1.2 to keep in sync with WinUI which is doing likewise to pick up memory leak fixes (#685) * Switch to Open Helix Queues (#665) (#706) Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> * Update MRTCore to .net 5.0.3 (#703) (#705) * Update MRTCore to .net 5.0.3 (#703) * Update MRTCore to .net 5.0.3 * Update runtime version * Change task display name * update to cswinrt 1.2.1 and .NET 5.0.5 (#715) * update to cswinrt 1.2.1 and .NET 5.0.5 * syncing with latest dotnet update changes * revert framework udk versions * update SDK.NET.Ref to 16 * update CsWinRT to 1.2.2 Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: Andrew Leader <aleader@microsoft.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com> Co-authored-by: Erik Torres <erik.torres.aguilar@gmail.com> Co-authored-by: Hui Chen <huichen@microsoft.com> Co-authored-by: Ben Kuhn <bjk4929@yahoo.com> Co-authored-by: Ben Kuhn <benkuhn@ntdev.microsoft.com> Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide option for force a particular VSIX version during runs of the VSIX build pipeline. Default for local builds or pipeline builds will still use a version adapted from Project Reunion. I tried a few different ways of putting this into the YAML, and while I'm sure it's possible, in the end I found it a lot simpler to bake this into the project file instead, just passing the option through to msbuild.