Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PLCrashReporter as submodule #2059

Merged

Conversation

MatkovIvan
Copy link
Contributor

@MatkovIvan MatkovIvan commented May 18, 2020

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Related PRs or issues

AB#79045

@codecov-io
Copy link

codecov-io commented May 18, 2020

Codecov Report

Merging #2059 into feature/support-catalyst will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/support-catalyst    #2059      +/-   ##
============================================================
- Coverage                     91.63%   91.62%   -0.01%     
============================================================
  Files                           129      113      -16     
  Lines                         10072     8263    -1809     
============================================================
- Hits                           9229     7571    -1658     
+ Misses                          843      692     -151     
Flag Coverage Δ
#iOS ?
#macOS 91.62% <100.00%> (+<0.01%) ⬆️
#tvOS ?
Impacted Files Coverage Δ
...enterCrashes/Internals/MSWrapperExceptionManager.m 100.00% <100.00%> (ø)
...CenterCrashes/Internals/Util/MSErrorLogFormatter.m 91.49% <100.00%> (-0.19%) ⬇️
AppCenterCrashes/AppCenterCrashes/MSCrashes.mm 85.18% <100.00%> (-0.37%) ⬇️
...nterAnalytics/Internals/Util/MSAnalyticsCategory.m 0.00% <0.00%> (-91.84%) ⬇️
...ush/Internal/DelegateForwarder/MSPushAppDelegate.m 78.37% <0.00%> (-19.76%) ⬇️
...ternals/DelegateForwarder/MSAppDelegateForwarder.m 67.64% <0.00%> (-14.33%) ⬇️
...warder/MSUserNotificationCenterDelegateForwarder.m 72.22% <0.00%> (-9.47%) ⬇️
.../Internals/DelegateForwarder/MSDelegateForwarder.m 80.00% <0.00%> (-9.42%) ⬇️
...ppCenter/AppCenter/Internals/Util/MSKeychainUtil.m 85.13% <0.00%> (-4.06%) ⬇️
...ppCenter/AppCenter/Internals/Util/MSUtility+File.m 90.43% <0.00%> (-0.33%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1364f5...2528425. Read the comment docs.

@annakocheshkova annakocheshkova force-pushed the feature/catalyst-plcr-submoodule branch from 7298089 to 0f2fdf7 Compare May 19, 2020 10:53
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #2059 into feature/support-catalyst will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/support-catalyst    #2059      +/-   ##
============================================================
- Coverage                     91.63%   91.38%   -0.25%     
============================================================
  Files                           129      113      -16     
  Lines                         10072     8413    -1659     
============================================================
- Hits                           9229     7688    -1541     
+ Misses                          843      725     -118     
Flag Coverage Δ
#iOS ?
#macOS 91.62% <ø> (ø)
#tvOS 91.04% <ø> (ø)
Impacted Files Coverage Δ
...nterAnalytics/Internals/Util/MSAnalyticsCategory.m 0.00% <0.00%> (-91.84%) ⬇️
...ternals/DelegateForwarder/MSAppDelegateForwarder.m 59.01% <0.00%> (-22.96%) ⬇️
...ush/Internal/DelegateForwarder/MSPushAppDelegate.m 78.37% <0.00%> (-19.76%) ⬇️
...warder/MSUserNotificationCenterDelegateForwarder.m 72.22% <0.00%> (-9.47%) ⬇️
.../Internals/DelegateForwarder/MSDelegateForwarder.m 85.88% <0.00%> (-3.53%) ⬇️
...enterDistribute/AppCenterDistribute/MSDistribute.m
...istribute/Internals/Version/MSSemVerPreReleaseId.m
...ibute/AppCenterDistribute/Model/MSReleaseDetails.m
...te/Internals/Model/MSDistributionStartSessionLog.m
...rDistribute/AppCenterDistribute/MSDistributeUtil.m
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d03d5c1...1dd4215. Read the comment docs.

@MatkovIvan
Copy link
Contributor Author

Merging to feature branch "as is", catalyst fixes will be merged in #2063

@MatkovIvan MatkovIvan marked this pull request as ready for review May 20, 2020 08:32
…eature/catalyst-plcr-submoodule

# Conflicts:
#	.gitmodules
#	AppCenterCrashes/AppCenterCrashes.xcodeproj/project.pbxproj
@annakocheshkova annakocheshkova merged commit 2346023 into feature/support-catalyst May 20, 2020
@annakocheshkova annakocheshkova deleted the feature/catalyst-plcr-submoodule branch May 20, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants