-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Catalyst support to Crashes #2063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/catalyst-resolve-feedback #2063 +/- ##
=====================================================================
+ Coverage 91.30% 91.52% +0.21%
=====================================================================
Files 113 129 +16
Lines 8429 10108 +1679
=====================================================================
+ Hits 7696 9251 +1555
- Misses 733 857 +124
Continue to review full report at Codecov.
|
6 tasks
Base automatically changed from
feature/catalyst-plcr-submoodule
to
feature/support-catalyst
May 20, 2020 10:43
…ix/catalyst-crashes # Conflicts: # .gitmodules # AppCenterCrashes/AppCenterCrashes.xcodeproj/project.pbxproj
5 tasks
…k' into fix/catalyst-crashes
annakocheshkova
changed the base branch from
feature/support-catalyst
to
feature/catalyst-resolve-feedback
May 20, 2020 11:25
…k' into fix/catalyst-crashes
…k' into fix/catalyst-crashes
annakocheshkova
changed the base branch from
feature/catalyst-resolve-feedback
to
fix/crashes-catalyst
May 21, 2020 11:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
HasCHANGELOG.md
been updated?Are the files formatted correctly?Did you add unit tests?Did you check UI tests on the sample app? They are not executed on CI.Description
Added check for TARGET_OS_MACCATALYST and fixed warnings.
AB#79045