Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catalyst support to Crashes #2063

Merged
merged 17 commits into from
May 21, 2020

Conversation

annakocheshkova
Copy link

@annakocheshkova annakocheshkova commented May 19, 2020

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Added check for TARGET_OS_MACCATALYST and fixed warnings.

AB#79045

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #2063 into feature/catalyst-resolve-feedback will increase coverage by 0.21%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/catalyst-resolve-feedback    #2063      +/-   ##
=====================================================================
+ Coverage                              91.30%   91.52%   +0.21%     
=====================================================================
  Files                                    113      129      +16     
  Lines                                   8429    10108    +1679     
=====================================================================
+ Hits                                    7696     9251    +1555     
- Misses                                   733      857     +124     
Flag Coverage Δ
#iOS 91.80% <79.31%> (?)
#macOS 91.48% <78.57%> (-0.06%) ⬇️
#tvOS 91.24% <79.31%> (+0.27%) ⬆️
Impacted Files Coverage Δ
AppCenterCrashes/AppCenterCrashes/MSCrashes.mm 85.18% <71.42%> (-0.38%) ⬇️
...enterCrashes/Internals/MSWrapperExceptionManager.m 100.00% <100.00%> (ø)
...CenterCrashes/Internals/Util/MSErrorLogFormatter.m 91.68% <100.00%> (ø)
AppCenterPush/AppCenterPush/MSPush.m 87.50% <0.00%> (-4.33%) ⬇️
...pCenter/Internals/Context/Device/MSDeviceTracker.m 92.36% <0.00%> (-0.36%) ⬇️
...enterDistribute/AppCenterDistribute/MSDistribute.m 89.05% <0.00%> (ø)
...istribute/AppCenterDistribute/MSBasicMachOParser.m 77.77% <0.00%> (ø)
...ribute/Internals/Channel/MSDistributeInfoTracker.m 100.00% <0.00%> (ø)
...nterDistribute/Internals/MSDistributeAppDelegate.m 100.00% <0.00%> (ø)
...pCenterDistribute/Internals/Model/MSErrorDetails.m 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed14fd...add01fc. Read the comment docs.

@MatkovIvan MatkovIvan mentioned this pull request May 20, 2020
6 tasks
@annakocheshkova annakocheshkova marked this pull request as ready for review May 20, 2020 10:35
Base automatically changed from feature/catalyst-plcr-submoodule to feature/support-catalyst May 20, 2020 10:43
…ix/catalyst-crashes

# Conflicts:
#	.gitmodules
#	AppCenterCrashes/AppCenterCrashes.xcodeproj/project.pbxproj
@annakocheshkova annakocheshkova mentioned this pull request May 20, 2020
5 tasks
@annakocheshkova annakocheshkova changed the base branch from feature/support-catalyst to feature/catalyst-resolve-feedback May 20, 2020 11:25
@annakocheshkova annakocheshkova changed the base branch from feature/catalyst-resolve-feedback to fix/crashes-catalyst May 21, 2020 11:43
@annakocheshkova annakocheshkova merged commit 80bd55f into fix/crashes-catalyst May 21, 2020
@annakocheshkova annakocheshkova deleted the fix/catalyst-crashes branch May 21, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants