[Feature] Catalyst support #2065

annakocheshkova · 2020-05-20T10:59:00Z

Things to consider before you submit the PR:

Has CHANGELOG.md been updated?
Are tests passing locally?
Are the files formatted correctly?
Did you add unit tests?
~~[ ] Did you check UI tests on the sample app? They are not executed on CI.~~
Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

AB#79037

Related PRs or issues

#2063

…macOS from the gethostuuid() conditional

Update sqlite3

Fix tests for Catalyst

…talyst # Conflicts: # Vendor/iOS/PLCrashReporter/include/CrashReporter.h # Vendor/iOS/PLCrashReporter/include/PLCrashFeatureConfig.h # Vendor/iOS/PLCrashReporter/include/PLCrashMacros.h # Vendor/iOS/PLCrashReporter/include/PLCrashReport.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportApplicationInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportBinaryImageInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportExceptionInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportMachExceptionInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportMachineInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportProcessInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportRegisterInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportSignalInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportStackFrameInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportSymbolInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportSystemInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReportThreadInfo.h # Vendor/iOS/PLCrashReporter/include/PLCrashReporter.h # Vendor/iOS/PLCrashReporter/libCrashReporter-iOS.a # Vendor/macOS/PLCrashReporter/include/CrashReporter.h # Vendor/macOS/PLCrashReporter/include/PLCrashFeatureConfig.h # Vendor/macOS/PLCrashReporter/include/PLCrashMacros.h # Vendor/macOS/PLCrashReporter/include/PLCrashReport.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportApplicationInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportBinaryImageInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportExceptionInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportMachExceptionInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportMachineInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportProcessInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportRegisterInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportSignalInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportStackFrameInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportSymbolInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportSystemInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReportThreadInfo.h # Vendor/macOS/PLCrashReporter/include/PLCrashReporter.h # Vendor/macOS/PLCrashReporter/libCrashReporter-MacOSX-Static.a # Vendor/tvOS/PLCrashReporter/include/CrashReporter.h # Vendor/tvOS/PLCrashReporter/include/PLCrashFeatureConfig.h # Vendor/tvOS/PLCrashReporter/include/PLCrashMacros.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReport.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportApplicationInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportBinaryImageInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportExceptionInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportMachExceptionInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportMachineInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportProcessInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportRegisterInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportSignalInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportStackFrameInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportSymbolInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportSystemInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReportThreadInfo.h # Vendor/tvOS/PLCrashReporter/include/PLCrashReporter.h # Vendor/tvOS/PLCrashReporter/libCrashReporter-tvOS.a # cgmanifest.json

AppCenter/AppCenter/Internals/Context/Device/MSDeviceTracker.m

AppCenterAnalytics/AppCenterAnalytics/TransmissionTarget/MSPropertyConfigurator.m

AppCenterCrashes/AppCenterCrashes/MSCrashes.mm

Config/Global.xcconfig

…scripts-test

…ll platforms

…eadme files

AppCenter/AppCenter/Internals/Util/MSUtility.m

CHANGELOG.md

AppCenterCrashes/AppCenterCrashes/Support/AppCenterCrashes.xcconfig

Co-authored-by: Ivan Matkov <v-ivmatk@microsoft.com>

Still need to be changed.

Fix missing push in xcframework test app

Fix SDK name reporting on Mac Catalyst

AppCenter/AppCenter/Internals/Context/Device/MSDeviceTracker.m

CHANGELOG.md

Jamminroot · 2020-06-01T12:49:06Z

CHANGELOG.md

+
+### App Center Analytics
+
+* **[Feature]** Add support for Mac Catalyst.


Not sure we need those duplicates

Jamminroot

Aside from nitpicks I mentioned, lgtm

Anastasia Kubova and others added 17 commits May 15, 2020 15:10

update sqlite binaries

2861818

In source code for sqlite was added the fix which excludes uikit for …

e84f464

…macOS from the gethostuuid() conditional

updated cgmanifest.json

8d2038a

Merge pull request #2056 from microsoft/feature/update-sqlite

ba9d8be

Update sqlite3

add OCHamcrest as a submodule

02e684c

remove OCHamcrest binaries

f85a32d

add OCHamcrest as a sub project

97a516d

Fix tests in Core for iOS and Catalyst

00a3880

Update cgmanifest

feff38c

Add cycle into xcframework build script

5e1602c

Remove extra references

71532d5

Merge pull request #2061 from microsoft/feature/catalyst-tests

d03d5c1

Fix tests for Catalyst

Add mac catalyst into build script

2c9e73e

Build command fixed

f0114bb

Add PLCrashReporter as submodule (#2059)

2346023

Add Catalyst support to Core (#2058)

ba959bf

Add Catalyst support to Analytics (#2057)

b9843fe

This comment has been minimized.

Sign in to view

Anna Kocheshkova and others added 4 commits May 21, 2020 18:56

Catalyst feedback and fixes (#2066)

50b3958

Support Catalyst for Crashes (#2070)

38bf521

Fixes for Catalyst SPM support (#2071)

cc14dcf

annakocheshkova marked this pull request as ready for review May 21, 2020 17:00

MatkovIvan suggested changes May 21, 2020

View reviewed changes

Anna Kocheshkova and others added 6 commits May 22, 2020 12:57

Add support for ios/macos

45d0e61

Merge branch 'feature/support-catalyst' into feature/catalyst-update-…

f470bb0

…scripts-test

remove intermediate coping for frameworks in main build scripts for a…

2621b79

…ll platforms

update docs script and update coping for the changelog, license and r…

4d4de6c

…eadme files

update the script for build xcframework

ae6dc5f

add dependencies for xcframework

3132926

iamclement reviewed May 29, 2020

View reviewed changes

AppCenter/AppCenter/Internals/Util/MSUtility.m Show resolved Hide resolved

Anna Kocheshkova added 2 commits May 29, 2020 11:29

Changelog

3d61ddc

Address style feedback

e54e750

MatkovIvan reviewed May 29, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

MatkovIvan reviewed May 29, 2020

View reviewed changes

AppCenterCrashes/AppCenterCrashes/Support/AppCenterCrashes.xcconfig Outdated Show resolved Hide resolved

Ruslan Urmeev and others added 3 commits May 29, 2020 17:00

Apply suggestions from code review

1271a78

Co-authored-by: Ivan Matkov <v-ivmatk@microsoft.com>

Update PLCR version to the latest master.

9b4b34e

Still need to be changed.

Revert OCMock update

73d830a

MatkovIvan previously approved these changes May 29, 2020

View reviewed changes

iamclement closed this May 29, 2020

iamclement reopened this May 29, 2020

MatkovIvan added 3 commits June 1, 2020 11:45

Fix missing push in xcframework test app

e01c08f

Fix SDK name reporting on Mac Catalyst

74f0d78

Merge pull request #2090 from microsoft/v-ivmatk/fix-test-app

34f7683

Fix missing push in xcframework test app

MatkovIvan dismissed their stale review via 34f7683 June 1, 2020 10:19

Merge pull request #2091 from microsoft/v-ivmatk/fix-sdk-name

be947d3

Fix SDK name reporting on Mac Catalyst

MatkovIvan previously approved these changes Jun 1, 2020

View reviewed changes

Jamminroot reviewed Jun 1, 2020

View reviewed changes

AppCenter/AppCenter/Internals/Context/Device/MSDeviceTracker.m Outdated Show resolved Hide resolved

Jamminroot reviewed Jun 1, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Jamminroot reviewed Jun 1, 2020

View reviewed changes

CHANGELOG.md

### App Center Analytics

* **[Feature]** Add support for Mac Catalyst.

Copy link

Contributor

Jamminroot Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need those duplicates

Jamminroot previously approved these changes Jun 1, 2020

View reviewed changes

Address feedback

0a9516d

MatkovIvan dismissed stale reviews from Jamminroot and themself via 0a9516d June 1, 2020 16:17

Update puppet test app secret

3105463

iamclement approved these changes Jun 1, 2020

View reviewed changes

MatkovIvan approved these changes Jun 1, 2020

View reviewed changes

MatkovIvan merged commit 1ff4957 into develop Jun 1, 2020

MatkovIvan deleted the feature/support-catalyst branch June 1, 2020 19:33

MatkovIvan mentioned this pull request Jun 2, 2020

Add support for mac Catalyst microsoft/appcenter#1578

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Catalyst support #2065

[Feature] Catalyst support #2065

annakocheshkova commented May 20, 2020 •

edited by MatkovIvan

Loading

This comment has been minimized.

Jamminroot Jun 1, 2020

Jamminroot left a comment


		### App Center Analytics

		* [Feature] Add support for Mac Catalyst.

[Feature] Catalyst support #2065

[Feature] Catalyst support #2065

Conversation

annakocheshkova commented May 20, 2020 • edited by MatkovIvan Loading

Description

Related PRs or issues

This comment has been minimized.

Jamminroot Jun 1, 2020

Choose a reason for hiding this comment

Jamminroot left a comment

Choose a reason for hiding this comment

annakocheshkova commented May 20, 2020 •

edited by MatkovIvan

Loading