Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK name reporting on Mac Catalyst #2091

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

MatkovIvan
Copy link
Contributor

@MatkovIvan MatkovIvan commented Jun 1, 2020

  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Fix SDK name reporting on Mac Catalyst.

No way to correctly set up it from SwiftPM config, so moving this def to header makes things much easier

Related PRs or issues

#2089
AB#80703

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #2091 into feature/support-catalyst will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/support-catalyst    #2091      +/-   ##
============================================================
- Coverage                     91.52%   91.49%   -0.03%     
============================================================
  Files                           129      129              
  Lines                         10133    10115      -18     
============================================================
- Hits                           9274     9255      -19     
- Misses                          859      860       +1     
Flag Coverage Δ
#MacCatalyst 91.39% <100.00%> (+<0.01%) ⬆️
#iOS 91.81% <100.00%> (+<0.01%) ⬆️
#macOS 90.92% <100.00%> (-0.54%) ⬇️
#tvOS 90.91% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
AppCenter/AppCenter/Internals/Util/MSUtility.m 56.00% <ø> (ø)
AppCenter/AppCenter/Internals/Util/MSUtility.h 100.00% <100.00%> (ø)
...r/AppCenter/Internals/Util/MSUtility+Application.m 33.33% <0.00%> (-7.94%) ⬇️
...nterAnalytics/Internals/Session/MSSessionTracker.m 100.00% <0.00%> (ø)
...lytics/TransmissionTarget/MSPropertyConfigurator.m 100.00% <0.00%> (ø)
...nterAnalytics/Internals/Util/MSAnalyticsCategory.m 100.00% <0.00%> (+8.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d830a...74f0d78. Read the comment docs.

@MatkovIvan MatkovIvan merged commit be947d3 into feature/support-catalyst Jun 1, 2020
@MatkovIvan MatkovIvan deleted the v-ivmatk/fix-sdk-name branch June 1, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants