cleaner definition of tool_responses fixes #1174#1182
Merged
sonichi merged 1 commit intomicrosoft:mainfrom Jan 9, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
===========================================
+ Coverage 30.41% 48.79% +18.37%
===========================================
Files 32 32
Lines 4301 4300 -1
Branches 993 1044 +51
===========================================
+ Hits 1308 2098 +790
+ Misses 2899 1998 -901
- Partials 94 204 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
I created PR #1184 today supporting streamed tool calls and I think I understand the new OpenAI API quite well now. I'll check this out carefully tomorrow, I am a bit too tired now. |
Contributor
sonichi
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I couldn't replicate #1174, but I could imagine how this could have created an empty tool_responses.
I could also do a defensive dict key filter on generate_oai_reply, but feels really dirty. ideally there would be built out types and then it would work to just take the keys from the dict that are needed for the type. But that is a bigger thing.
Related issue number
Closes #1174
Checks