Skip to content

Conversation

@sonichi
Copy link
Contributor

@sonichi sonichi commented Jan 9, 2024

Why are these changes needed?

Need to check whether tool_returns is empty before returning.
TODO in a separate PR: add a test to cover human_input_mode="ALWAYS"

Related issue number

Close #1174

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2ca8aae) 30.41% compared to head (6334cf8) 39.50%.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   30.41%   39.50%   +9.09%     
==========================================
  Files          32       32              
  Lines        4301     4303       +2     
  Branches      993     1045      +52     
==========================================
+ Hits         1308     1700     +392     
+ Misses       2899     2477     -422     
- Partials       94      126      +32     
Flag Coverage Δ
unittests 39.43% <25.00%> (+9.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Contributor

ekzhu commented Jan 9, 2024

Are this and #1182 both required to close the bug #1174 ?

@sonichi
Copy link
Contributor Author

sonichi commented Jan 9, 2024

Are this and #1182 both required to close the bug #1174 ?

I think so. They cover different cases. Similar to this PR, a test should be added to cover the case in #1182.

Copy link
Contributor

@yenif yenif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yup thats it

@sonichi sonichi added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 78fe8f9 Jan 10, 2024
@sonichi sonichi deleted the i1174 branch January 10, 2024 01:39
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* check tool_returns

* bump version to 0.2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Async_human_input openai.BadRequestError

5 participants