Fix/transformer aware any modelfamily #6213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Contributor
|
Thanks! I confirm this fixes the issue I noted #6011 (comment) |
ekzhu
approved these changes
Apr 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6213 +/- ##
==========================================
- Coverage 77.25% 77.25% -0.01%
==========================================
Files 200 200
Lines 14243 14246 +3
==========================================
+ Hits 11004 11006 +2
- Misses 3239 3240 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peterj
added a commit
to kagent-dev/autogen
that referenced
this pull request
Apr 11, 2025
* upstream/main: (120 commits) Update discover.md with adding email agent package (microsoft#6274) Expose TCM TypedDict classes for apps to use (microsoft#6269) Fix publish_message-method() notes (microsoft#6250) Fix ValueError: Dataclass has a union type error (microsoft#6266) [Bugfix] Fix for Issue microsoft#6241 - ChromaDB removed IncludeEnum (microsoft#6260) Add note on ModelInfo for Gemini Models (microsoft#6259) .NET update autogen 0.2.2 -> autogen 0.2.3 (microsoft#6257) [Draft] Enable File Upload/Paste as Task in AGS (microsoft#6091) Bugfix/azure ai search embedding (microsoft#6248) Expose more Task-Centric Memory parameters (microsoft#6246) fix: typo in usage.md (microsoft#6245) .NET update oai and aoai package version (microsoft#6239) Fix sha256_hash docstring (microsoft#6236) Update json_schema_to_pydantic version and make relaxed requirement on arry item. (microsoft#6209) Fix terminations conditions. (microsoft#6229) Docker Code Exec delete temp files (microsoft#6211) clean codes notes for autogen-core. (microsoft#6218) Fix/transformer aware any modelfamily (microsoft#6213) chore: Add powershell path check for code executor (microsoft#6212) added: gemini 2.5 pro preview (microsoft#6226) ... Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR improves fallback safety when an invalid
model_familyis supplied toget_transformer(). Previously, if a user passed an arbitrary or incorrectfamilystring inmodel_info, the lookup could fail without falling back toModelFamily.UNKNOWN.Now, we explicitly check whether
model_familyis a valid value inModelFamily.ANY. If not, we fallback to_find_model_family()as intended.Related issue number
Related #6011#issuecomment-2779957730
Checks