Skip to content

Conversation

@lspinheiro
Copy link
Collaborator

Why are these changes needed?

Addresses the follow up error in #5518 , it will now check if both powershell or pwsh are in the path and throw a value error if neither is available.

Related issue number

Checks

@lspinheiro lspinheiro requested review from ekzhu and jackgerrits April 5, 2025 02:13
@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (b1ae4ac) to head (a06cb95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ogen-ext/src/autogen_ext/code_executors/_common.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6212      +/-   ##
==========================================
- Coverage   77.27%   77.25%   -0.03%     
==========================================
  Files         200      200              
  Lines       14238    14243       +5     
==========================================
+ Hits        11003    11004       +1     
- Misses       3235     3239       +4     
Flag Coverage Δ
unittests 77.25% <16.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu enabled auto-merge (squash) April 6, 2025 02:34
@ekzhu ekzhu merged commit faf2a4e into microsoft:main Apr 6, 2025
56 checks passed
peterj added a commit to kagent-dev/autogen that referenced this pull request Apr 11, 2025
* upstream/main: (120 commits)
  Update discover.md with adding email agent package (microsoft#6274)
  Expose TCM TypedDict classes for apps to use (microsoft#6269)
  Fix publish_message-method() notes (microsoft#6250)
  Fix ValueError: Dataclass has a union type error (microsoft#6266)
  [Bugfix] Fix for Issue microsoft#6241 - ChromaDB removed IncludeEnum (microsoft#6260)
  Add note on ModelInfo for Gemini Models (microsoft#6259)
  .NET update autogen 0.2.2 -> autogen 0.2.3 (microsoft#6257)
  [Draft] Enable File Upload/Paste as Task in AGS (microsoft#6091)
  Bugfix/azure ai search embedding (microsoft#6248)
  Expose more Task-Centric Memory parameters (microsoft#6246)
  fix: typo in usage.md (microsoft#6245)
  .NET update oai and aoai package version (microsoft#6239)
  Fix sha256_hash docstring (microsoft#6236)
  Update json_schema_to_pydantic version and make relaxed requirement on arry item. (microsoft#6209)
  Fix terminations conditions. (microsoft#6229)
  Docker Code Exec delete temp files (microsoft#6211)
  clean codes notes for autogen-core. (microsoft#6218)
  Fix/transformer aware any modelfamily (microsoft#6213)
  chore: Add powershell path check for code executor (microsoft#6212)
  added: gemini 2.5 pro preview (microsoft#6226)
  ...

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants