Skip to content

Update: override return_value_as_string for McpToolAdapter #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ekzhu merged 5 commits into from
Apr 24, 2025
Merged

Update: override return_value_as_string for McpToolAdapter #6371

ekzhu merged 5 commits into from
Apr 24, 2025

Conversation

@perfogic
Copy link
Contributor

@perfogic perfogic commented Apr 23, 2025

Why are these changes needed?

  • Add return_value_as_string for formating result from MCP tool

Related issue number

Checks

@perfogic
Copy link
Contributor Author

perfogic commented Apr 23, 2025

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@perfogic
Copy link
Contributor Author

perfogic commented Apr 23, 2025 •
edited
Loading

@ekzhu can you give me a check ? Thanks for your time!

ekzhu
ekzhu suggested changes Apr 23, 2025
View reviewed changes
@perfogic perfogic requested a review from ekzhu April 23, 2025 19:41
@ekzhu ekzhu changed the base branch from ekzhu-workbench to main April 24, 2025 03:49
@ekzhu ekzhu changed the base branch from main to ekzhu-workbench April 24, 2025 03:50
@ekzhu ekzhu merged commit aee4aae into microsoft:ekzhu-workbench Apr 24, 2025
3 checks passed
ekzhu added a commit that referenced this pull request Apr 24, 2025
@ekzhu
Revert "Update: override return_value_as_string for McpToolAdapter (#…
8277779 
…6371)"

This reverts commit aee4aae.
@ekzhu ekzhu mentioned this pull request Apr 24, 2025
Merged
ekzhu added a commit that referenced this pull request Apr 24, 2025
@ekzhu
Revert "Update: override return_value_as_string for McpToolAdapter" (#…
a753bc2 
…6378)

Reverts #6371
@ekzhu
Copy link
Contributor

ekzhu commented Apr 24, 2025

@perfogic sorry. I didn't notice your PR is targeting ekzhu-workbench branch. I had to revert it. Can you create a new PR targeting the main branch?

@perfogic
Copy link
Contributor Author

perfogic commented Apr 24, 2025

sure let's me do it @ekzhu

@perfogic
Copy link
Contributor Author

perfogic commented Apr 24, 2025 •
edited
Loading

new PR is on #6380, please give it a check! @ekzhu

@peterychang peterychang mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ekzhu ekzhu ekzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perfogic @ekzhu