Update: implement return_value_as_string for McpToolAdapter #6380
Merged
ekzhu merged 10 commits intomicrosoft:mainfrom Apr 25, 2025
Merged
Update: implement return_value_as_string for McpToolAdapter #6380ekzhu merged 10 commits intomicrosoft:mainfrom
ekzhu merged 10 commits intomicrosoft:mainfrom
Conversation
3 tasks
Contributor
Author
|
@ekzhu Can you check my new PR ? Thanks for your time! |
perfogic
changed the title
ekzhu
reviewed
Apr 24, 2025
Contributor
ekzhu
left a comment
ekzhu
left a comment
There was a problem hiding this comment.
Can you run poe pyright and poe mypy in python/packages/autogen-ext to make sure the type checks pass?
Contributor
|
Read |
Contributor
Author
yeah, i'm fixing it now |
Contributor
Author
|
@ekzhu can you review it again, thanks for your time! I believe all the tests will be passed now! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6380 +/- ##
==========================================
+ Coverage 78.38% 78.40% +0.01%
==========================================
Files 221 221
Lines 16024 16042 +18
==========================================
+ Hits 12560 12577 +17
- Misses 3464 3465 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peterj
added a commit
to kagent-dev/autogen
that referenced
this pull request
Apr 26, 2025
…n0425 * upstream/main: Update website for v0.5.5 (microsoft#6401) Document custom message types in teams API docs (microsoft#6400) [doc] Clarify selector prompt for SelectorGroupChat (microsoft#6399) Add functional termination condition (microsoft#6398) Update: implement return_value_as_string for McpToolAdapter (microsoft#6380) Update version to 0.5.5 (microsoft#6397) Add example using autogen-core and FastAPI for handoff multi-agent design pattern with streaming and UI (microsoft#6391) Update agent documentation (microsoft#6394) AssistantAgent to support Workbench (microsoft#6393) TEST: skip when macos+uv and adding uv venv tests (microsoft#6387) Add guide for workbench and mcp & bug fixes for create_mcp_server_session (microsoft#6392) Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
McpToolAdapterto implementreturn_value_as_string#6368Checks