L0 tests for Xamarin tasks #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jpricket
commented
May 16, 2016
jpricket
commented
- This PR includes lots of tests for XamarinAndroid, XamarinRestoreComponent, XamarinTestCloud, and XamariniOS. The tests for XamarinLicense are limited because the task cannot be easily mocked.
- I added the ability for which(..., true) to call CheckPath in the test library to allow for testing the scenario when it doesn't exist. This required updating lots of response files for tests that didn't have the CheckPath set on the paths that which returned.
| xbuildToolPath = xbuildLocation + '/xbuild'; | ||
| xbuildToolPath = path.join(xbuildLocation, 'xbuild'); | ||
| if (!tl.exist(xbuildToolPath)) { | ||
| xbuildToolPath = path.join(xbuildLocation, 'xbuild.exe'); |
There was a problem hiding this comment.
Why are we doing the explicit check for xbuild.exe?
There was a problem hiding this comment.
This was to handle running it on Windows or *nix. On Windows it has the extension .exe, but not on other OSes. Is there a better way?
There was a problem hiding this comment.
there is a way to check for os version like we do in Xamarin Licensing task.
There was a problem hiding this comment.
Unfortunately, there isn't a way to mock that OS check. That's why I tried to avoid that here. The TaskLib really needs a method that allows the task to check the OS (tl.isWin). That way it could be mocked and all paths can be fully tested.
|
Looks good to me with minor comments. |
…ges to mock task-lib)
… CheckPath in the test library.
- no need to log inputs, getInput does that - don't use tl.exit, use setResult
jpricket
force-pushed
the
users/jpricket/L0
branch
from
49b214d to
dec1b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.