Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry not logging ActivityID and ConversationID. #6616

Closed
tracyboehrer opened this issue Apr 6, 2023 · 0 comments · Fixed by #6620
Closed

Telemetry not logging ActivityID and ConversationID. #6616

tracyboehrer opened this issue Apr 6, 2023 · 0 comments · Fixed by #6620
Assignees

Comments

@tracyboehrer
Copy link
Member

It is a problem which happened only on directline extension, neither in directline nor webchat it will happen.

As we known,
1), in directline/webchat, client connect to directline via https and directline connect to bot via https

image

2), in directline extension, client connect to directline extension via websocket and directline connect to bot via named pipe

image

In BotFramework OpenSource SDK, we can found that SDK use HttpContext to store activity and log it to telemetry.

where to store it: botbuilder-dotnet/libraries at main · microsoft/botbuilder-dotnet · GitHub

where to log it to telemetry: botbuilder-dotnet/libraries at main · microsoft/botbuilder-dotnet · GitHub

In above, we had metioned that in directline/webchat, directline connect to bot via https, so it has a non-null HttpContext, but in directline extension, extension connect to bot via named pipe, and the value of HttpContext is null, and I think it is an SDK bug.

Then it will lead to both conversationid and activityid not log into telemetry.

tracyboehrer pushed a commit that referenced this issue Apr 20, 2023
* Added ActivityIdProperty to TelemetryConstants. Added ConversationId and ActivityId to TelemetryLoggerMiddleware.

* Remove duplicated conversationId properties

* Update tests in TelemetryMiddlewareTests

---------

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
Co-authored-by: CeciliaAvila <cecilia.avila@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants