Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6616] Telemetry not logging ActivityID and ConversationID #6620

Conversation

erquirogasw
Copy link
Contributor

Fixes #6616

Description

This PR adds ActivityID and ConversationID properties to telemetry when using the Direct Line Service App extension.

Specific Changes

  • Added ActivityIdProperty property in TelemetryConstants class.
  • Added ActivityID and ConversationID properties in the Fill methods in TelemetryLoggerMiddleware class.
  • Updated unit tests in TelemetryMiddlewareTests.

Testing

The following images show the properties logged in Application Insights and the unit tests passing.
iCEpwqKIwW (1)
w4N1IsNF4p

@erquirogasw erquirogasw added the Automation: Parity with js The PR needs to be ported to JS label Apr 17, 2023
@erquirogasw erquirogasw requested a review from a team as a code owner April 17, 2023 17:44
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 348112

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 79.082%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
/libraries/Microsoft.Bot.Builder/TelemetryLoggerMiddleware.cs 22 71.24%
Totals Coverage Status
Change from base Build 344537: -0.02%
Covered Lines: 25813
Relevant Lines: 32641

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

@tracyboehrer tracyboehrer merged commit c855a1f into main Apr 20, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/telemetry-not-logging-activityid-and-conversationid branch April 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry not logging ActivityID and ConversationID.
5 participants