Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6616] Telemetry not logging ActivityID and ConversationID #4466

Closed
ceciliaavila opened this issue Apr 27, 2023 · 0 comments · Fixed by #4471
Closed

port: [#6616] Telemetry not logging ActivityID and ConversationID #4466

ceciliaavila opened this issue Apr 27, 2023 · 0 comments · Fixed by #4471
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#6616] Telemetry not logging ActivityID and ConversationID may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6616

Description

This PR adds ActivityID and ConversationID properties to telemetry when using the Direct Line Service App extension.

Specific Changes

  • Added ActivityIdProperty property in TelemetryConstants class.
  • Added ActivityID and ConversationID properties in the Fill methods in TelemetryLoggerMiddleware class.
  • Updated unit tests in TelemetryMiddlewareTests.

Testing

The following images show the properties logged in Application Insights and the unit tests passing.
iCEpwqKIwW (1)
w4N1IsNF4p
@ceciliaavila ceciliaavila added bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms. labels Apr 27, 2023
@ceciliaavila ceciliaavila self-assigned this Apr 27, 2023
@sw-joelmut sw-joelmut mentioned this issue May 3, 2023
Merged
tracyboehrer pushed a commit that referenced this issue May 5, 2023
@sw-joelmut
fix: [#4466] Fix telemetry activityId and conversationId properties (#…
c3c1bf1 
…4471)

* Fix telemetry activityId and conversationId properties

* Fix when responses come empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#4466] Fix telemetry activityId and conversationId properties microsoft/botbuilder-js
1 participant
@ceciliaavila