Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass exceptions on Faulted Tasks as inner Exceptions. #140

Merged
merged 3 commits into from
Feb 17, 2018

Commits on Feb 16, 2018

  1. Configuration menu
    Copy the full SHA
    7fda896 View commit details
    Browse the repository at this point in the history
  2. Surface exceptions more cleanly from TestAdapter

     * Some `TestAdapter` methods are creating task continuations of `Task<Task>`, but were not using `.Unwrap()` and so exceptions that might have been thrown by the result `Task` were not being surfaced correctly.
     * Instead of testing `.IsFaulted` and throwing an `Exception` that wraps the antecedent `Tasks` exception manually, just use `Task::Wait` to observe the original exception and naturally propagate that up the chain.
     * Add test that simulates an exception being thrown from `Bot::OnReceive` so we have proper coverage of that scenario.
    Drew Marsh committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    0fbfbe3 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. Minor Comment changes

    cleemullins committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    8c51928 View commit details
    Browse the repository at this point in the history