Pass exceptions on Faulted Tasks as inner Exceptions. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleemullins
added
bug
|
Hey @cleemullins I've got a potential test case that I'm about to PR to your branch if you want to review it. It may make it easier to test your change directly. Edit here's the PR: #142 |
* Some `TestAdapter` methods are creating task continuations of `Task<Task>`, but were not using `.Unwrap()` and so exceptions that might have been thrown by the result `Task` were not being surfaced correctly. * Instead of testing `.IsFaulted` and throwing an `Exception` that wraps the antecedent `Tasks` exception manually, just use `Task::Wait` to observe the original exception and naturally propagate that up the chain. * Add test that simulates an exception being thrown from `Bot::OnReceive` so we have proper coverage of that scenario.
|
Reviews in person with Drew. |
ceciliaavila
pushed a commit
that referenced
this pull request
Jun 25, 2019
…issues [StyleCop] Fix warnings on SlackBotWorker and SlackDialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #135.
Note that while I added tests, I couldn't get a test that actually exercised the new behavior.
The behavior in this new code is clearly better, but how to get these tests to fault while using the standard semantics is complicated.
I would be very interested in seeing a solution to how to test this.