Added test case to test the Exception aggregation

[RyanDawkins]

Added test case to test the Exception aggregation

[cleemullins]

This is great.

@drub0y has a major set of changes to the TestAdapter coming tonight / tomorrow that fixes problems in how Tasks are handled in exceptional cases. Specifically he's unwinding Tasks and handling and a few corner cases that I'm not sure I understand.

If you don't mind, let's wait on this PR until that one is in, then we can bring the revised test over.

[drub0y]

Those changes just went in and added one more test to the suite to cover the scenario where the exception happens in OnReceive. It also changes the exception handling so that the underlying exception propagates more "naturally" through the task chain as a AggregateException. Glancing at the test you added here it should work exactly the same way since you're checking the inner exception's type. So if you rebate against my commit and rerun it should "just work". 😊

[cleemullins]

Are you on skype? Or teams? Or slack?

…

________________________________ From: Drew Marsh <notifications@github.com> Sent: Friday, February 16, 2018 9:55:59 PM To: Microsoft/botbuilder-dotnet Cc: Chris Mullins; Comment Subject: Re: [Microsoft/botbuilder-dotnet] Added test case to test the Exception aggregation (#142) Those changes just went in and added one more test to the suite to cover the scenario where the exception happens in OnReceive. It also changes the exception handling so that the underlying exception propagates more "naturally" through the task chain as a AggregateException. Glancing at the test you added here it should work exactly the same way since you're checking the inner exception's type. So if you rebate against my commit and rerun it should "just work". 😊 — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fbotbuilder-dotnet%2Fpull%2F142%23issuecomment-366419636&data=04%7C01%7Ccmullins%40microsoft.com%7C706deeccab964b060a8508d575cb1f33%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636544437615432135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=%2B4GzZeB7Jw6EfnyRjF2Bu1I9AqGheuud6FhI9adeh%2F0%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABHICeMSz___o8zDv-Wvarlh6xGLPMwyks5tVmnvgaJpZM4SI2Ya&data=04%7C01%7Ccmullins%40microsoft.com%7C706deeccab964b060a8508d575cb1f33%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636544437615432135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=Bo2aoaS74l5IxGq3%2FO8dZAVGy6VpE7zjd3rtSoLrH%2FM%3D&reserved=0>.

[cleemullins]

Merged.

…

________________________________ From: Drew Marsh <notifications@github.com> Sent: Friday, February 16, 2018 9:55:59 PM To: Microsoft/botbuilder-dotnet Cc: Chris Mullins; Comment Subject: Re: [Microsoft/botbuilder-dotnet] Added test case to test the Exception aggregation (#142) Those changes just went in and added one more test to the suite to cover the scenario where the exception happens in OnReceive. It also changes the exception handling so that the underlying exception propagates more "naturally" through the task chain as a AggregateException. Glancing at the test you added here it should work exactly the same way since you're checking the inner exception's type. So if you rebate against my commit and rerun it should "just work". 😊 — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fbotbuilder-dotnet%2Fpull%2F142%23issuecomment-366419636&data=04%7C01%7Ccmullins%40microsoft.com%7C706deeccab964b060a8508d575cb1f33%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636544437615432135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=%2B4GzZeB7Jw6EfnyRjF2Bu1I9AqGheuud6FhI9adeh%2F0%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABHICeMSz___o8zDv-Wvarlh6xGLPMwyks5tVmnvgaJpZM4SI2Ya&data=04%7C01%7Ccmullins%40microsoft.com%7C706deeccab964b060a8508d575cb1f33%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636544437615432135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=Bo2aoaS74l5IxGq3%2FO8dZAVGy6VpE7zjd3rtSoLrH%2FM%3D&reserved=0>.

[RyanDawkins]

I'm about to pull in the changes if you pulled stuff into your branch.

[RyanDawkins]

@cleemullins I can close this PR and open another for master? I noticed you already merged your branch in.

Edit: I'm going to close it anyways because now I'm just updating your branch with master.