CosmosDbPartitionedStorage using v3 SDK.

[garypretty]

Addresses DCR #5467 microsoft/botframework-sdk#5467

@cleemullins @mdrichardson This is the initial version of the new CosmosDbPartitionedStorage class - I would appreciate your review before I move any further forward.

• The new implementation no longer handles database creation. We only handle container creation.
• Uses the new v3 SDK
• Implements partitioning for the user, with the option to pass in a key now gone. We utilize the ID of the item as the partition key.

Tests still need adding following initial review.

[mdrichardson]

CC: @cleemullins

@garypretty I should've mentioned this yesterday and haven't read through the code enough to see if this is being addressed, but one MAJOR issue with not handling database creation is that Azure Portal requires a user to enter a PartitionKeyPath. It would be very easy for them to set the wrong one. We'd either need really good error reporting or some way to proactively let the user know what PartitionKeyPath to set (docs maybe, but they're not read enough, usually)

Edit: I am the dumb.

[garypretty]

@mdrichardson Database creation in the Azure portal doesn't require the partition key path - container creation does (at least from my testing so far). We handle the container, but the user handles the master database.

[mdrichardson]

@garypretty Ah, shoot. You're right. Disregard.

[fuselabs]

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

[mdrichardson]

LGTM. Read, Write, and Delete all worked. When writing tests for this, I wouldn't base them off of the existing PartitionKey tests...they don't accurately reflect how the SDK works.

[fuselabs]

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

[mdrichardson]

Needs tests. Removing approval.

[garypretty]

@mdrichardson I have now added tests. I am running all of the base storage tests and all tests are passing. Also made an amendment to the storage class itself to handle reading multiple keys (I realize this isn't something we do at the moment, but I wanted to ensure consistency between the different storage providers).

[coveralls]

Pull Request Test Coverage Report for Build 81133

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 162 unchanged lines in 9 files lost coverage.
• Overall coverage decreased (-2.4%) to 78.281%

---

Files with Coverage Reduction	New Missed Lines	%
/libraries/Microsoft.Bot.Builder/ConversationState.cs	1	80.0%
/libraries/Microsoft.Bot.Builder/UserState.cs	1	80.0%
/libraries/Microsoft.Bot.Builder/PrivateConversationState.cs	2	66.67%
/libraries/Microsoft.Bot.Builder/TelemetryLoggerMiddleware.cs	2	98.4%
/libraries/Microsoft.Bot.Builder/ActivityHandler.cs	4	85.71%
/libraries/Microsoft.Bot.Builder/Integration/BotFrameworkOptions.cs	4	58.33%
/libraries/Microsoft.Bot.Builder/TurnContext.cs	4	89.47%
/libraries/Microsoft.Bot.Builder/BotState.cs	10	85.87%
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs	134	39.1%

Totals
Change from base Build 80657:	-2.4%
Covered Lines:	4455
Relevant Lines:	5691

---

💛 - Coveralls

[fuselabs]

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

[mdrichardson]

LGTM. Ran all of the tests and watched storage change appropriately as the tests hit a number of breakpoints. Good stuff!

[garypretty]

New partitioned storage provider now in C# with other language implementations following shortly.