Cosmos partitioning #1282
Merged
Cosmos partitioning #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
christopheranderson
approved these changes
Oct 9, 2019
|
@christopheranderson Great feedback! I should be able to fix those tomorrow. |
Pull Request Test Coverage Report for Build 83263
💛 - Coveralls |
cleemullins
approved these changes
Oct 10, 2019
|
Please merge when ready. |
|
@cleemullins Will do. Implementing @christopheranderson's recommendations now and will merge once build tests passes. However, coveralls test coverage won't allow merge. I believe the issue is that most of the tests don't actually run since there's no Storage Emulator. Is that something we can bypass? ...I don't believe any of the JS storage tests actually run the read/write/deletes in the pipeline tests. |
|
@mdrichardson @christopheranderson Let's discuss handling non partitioned etc tomorrow when you get online. I have some specific thoughts here. |
added 5 commits
October 10, 2019 16:04
…nto cosmosPartitioning
…botbuilder-js into cosmosPartitioning
mdrichardson
changed the title
mdrichardson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234
Description
Parity with Dotnet, adding a separate class for supporting Partitioned Containers on Cosmos.
Specific Changes
@azure/cosmosSDKAlso implements these additional changes from the Dotnet PR
Testing
Added new, separate tests.
On a side note: I plan to eventually create a StorageBaseTests class for the JS repo, so we remove a lot of the duplicate code. Wanted to get this out for 4.6, though.