Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct header schema for BeginSkill #5767

Merged
merged 3 commits into from
Jul 8, 2021
Merged

use correct header schema for BeginSkill #5767

merged 3 commits into from
Jul 8, 2021

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jul 7, 2021 •
edited
Loading

refs microsoft/BotFramework-Composer#8253

Description

Nests header specific configuration in a header object.

#minor

@a-b-r-o-w-n a-b-r-o-w-n requested review from a team as code owners July 7, 2021 19:06
@coveralls
Copy link
Collaborator

coveralls commented Jul 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 257210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 76.151%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Generators/MultiLanguageGeneratorBase.cs 1 81.48%
Totals Coverage Status
Change from base Build 256939: 0.003%
Covered Lines: 23114
Relevant Lines: 30353
💛 - Coveralls

@mrivera-ms
Copy link
Contributor

/azp run BotBuilder-DotNet-CI-PR-(MacLinux)-yaml

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mrivera-ms
Copy link
Contributor

/azp run BotBuilder-DotNet-CI-PR-(MacLinux)-yaml

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mrivera-ms mrivera-ms merged commit 7d2bb5c into main Jul 8, 2021
@mrivera-ms mrivera-ms deleted the abrown/update-begin-skill-uischema branch July 8, 2021 17:37
This was referenced Jul 8, 2021
Closed
Closed
Closed
mrivera-ms added a commit that referenced this pull request Jul 8, 2021
@a-b-r-o-w-n @mrivera-ms
use correct header schema for BeginSkill (#5767)
9283a2a 
* use correct header schema for BeginSkill

* Update tests.uischema

Co-authored-by: Monica Rivera <moniriv@microsoft.com>
@mrivera-ms mrivera-ms mentioned this pull request Jul 8, 2021
Merged
mrivera-ms added a commit that referenced this pull request Jul 8, 2021
@mrivera-ms @a-b-r-o-w-n
use correct header schema for BeginSkill (#5767) (#5774)
4e77424 
* use correct header schema for BeginSkill

* Update tests.uischema

Co-authored-by: Monica Rivera <moniriv@microsoft.com>

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivera-ms mrivera-ms mrivera-ms approved these changes

@tomlm tomlm Awaiting requested review from tomlm

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @coveralls @mrivera-ms