Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: use correct header schema for BeginSkill (#5767) #3853

Closed
github-actions bot opened this issue Jul 8, 2021 · 0 comments · Fixed by #3854
Closed

port: use correct header schema for BeginSkill (#5767) #3853

github-actions bot opened this issue Jul 8, 2021 · 0 comments · Fixed by #3854
Assignees
@joshgummersall
Labels
Area: Adaptive The issue is related to Adaptive dialogs parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

The changes in use correct header schema for BeginSkill (#5767) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

refs microsoft/BotFramework-Composer#8253

Description

Nests header specific configuration in a header object.

#minor

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jul 8, 2021
@joshgummersall joshgummersall self-assigned this Jul 8, 2021
@joshgummersall joshgummersall added Area: Adaptive The issue is related to Adaptive dialogs and removed ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jul 8, 2021
joshgummersall pushed a commit that referenced this issue Jul 8, 2021
port: beginskill uischema fix
bfa84f9 
Fixes #3853
@joshgummersall joshgummersall mentioned this issue Jul 8, 2021
Merged
stevengum pushed a commit that referenced this issue Jul 8, 2021
port: beginskill uischema fix (#3854)
cc4fe2d 
Fixes #3853
joshgummersall pushed a commit that referenced this issue Jul 15, 2021
port: beginskill uischema fix (#3854)
18e07ab 
Fixes #3853
stevengum pushed a commit that referenced this issue Jul 15, 2021
@taicchoumsft
chore: cherrypick changes for 4.14.1 (#3871)
8590995 
* port: beginskill uischema fix (#3854)

Fixes #3853

* make getTopScoringIntent return '' instead of undefined (#3870)

Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

Labels
Area: Adaptive The issue is related to Adaptive dialogs parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: beginskill uischema fix microsoft/botbuilder-js
1 participant
@joshgummersall