Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: beginskill uischema fix #3854

Merged
merged 1 commit into from
Jul 8, 2021
Merged

port: beginskill uischema fix #3854

merged 1 commit into from
Jul 8, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3853

@joshgummersall joshgummersall requested review from a team as code owners July 8, 2021 18:48
@coveralls
Copy link

coveralls commented Jul 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1012717724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.341%
Totals Coverage Status
Change from base Build 1008943513: 0.0%
Covered Lines: 19671
Relevant Lines: 22128
💛 - Coveralls

mdrichardson
mdrichardson approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough

@stevengum stevengum merged commit cc4fe2d into main Jul 8, 2021
@stevengum stevengum deleted the jpg/port-beginskill-uischema branch July 8, 2021 20:25
joshgummersall pushed a commit that referenced this pull request Jul 15, 2021
port: beginskill uischema fix (#3854)
18e07ab 
Fixes #3853
stevengum pushed a commit that referenced this pull request Jul 15, 2021
@taicchoumsft
chore: cherrypick changes for 4.14.1 (#3871)
8590995 
* port: beginskill uischema fix (#3854)

Fixes #3853

* make getTopScoringIntent return '' instead of undefined (#3870)

Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: use correct header schema for BeginSkill (#5767)
4 participants
@joshgummersall @coveralls @mdrichardson @stevengum