Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logging to CloudAdapter.ProcessAsync() #6581

Closed
wants to merge 1 commit into from
Closed

Add Logging to CloudAdapter.ProcessAsync() #6581

wants to merge 1 commit into from

Conversation

ramfattah
Copy link
Contributor

Fixes #6577

@ramfattah ramfattah requested a review from a team as a code owner January 25, 2023 07:21
@ramfattah ramfattah added the Automation: No parity PR does not need to be applied to other languages. label Jan 25, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 338120

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.005%) to 73.353%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 21 76.87%
Totals Coverage Status
Change from base Build 337253: -0.005%
Covered Lines: 23946
Relevant Lines: 32645
💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll

@ramfattah ramfattah closed this Feb 10, 2023
@ramfattah
Copy link
Contributor Author

See #6587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can you add a log line for this exception?
3 participants
@ramfattah @coveralls @BruceHaley