Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added log to ProcessAsync method in CloudAdapter.cs. #6587

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Added log to ProcessAsync method in CloudAdapter.cs. #6587

merged 4 commits into from
Feb 10, 2023

Conversation

erquirogasw
Copy link
Contributor

Fixes #6577

Description

This PR adds a log in the ProcessAsync method of the CloudAdapter class to show more information about the UnauthorizedAccessException exceptions.
Additionally, it updates the CloudAdapter unit tests.

Specific Changes

  • Added log to ProcessAsync method in CloudAdapter.cs.
  • Updated ExpiredTokenShouldThrowUnauthorizedAccessException unit test in CloudAdapterTests.cs.

Testing

The following image shows the error message with the new log.
image

The updated test passing.
image

@erquirogasw erquirogasw added the Automation: Parity with js The PR needs to be ported to JS label Feb 10, 2023
@erquirogasw erquirogasw requested a review from a team as a code owner February 10, 2023 18:58
@ramfattah ramfattah mentioned this pull request Feb 10, 2023
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 340162

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+5.8%) to 79.114%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 21 76.87%
Totals Coverage Status
Change from base Build 337253: 5.8%
Covered Lines: 25841
Relevant Lines: 32663
💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll

@tracyboehrer tracyboehrer merged commit 7503fd7 into main Feb 10, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/log-line-for-UnauthorizedAccessException branch February 10, 2023 21:32
@tracyboehrer tracyboehrer changed the title [#6577] Can you add a log line for this exception? Added log to ProcessAsync method in CloudAdapter.cs. Feb 13, 2023
tracyboehrer pushed a commit that referenced this pull request Feb 13, 2023
@erquirogasw
[#6577] Can you add a log line for this exception? (#6587)
daac32c 
* Added log in ProcessAsync method. Updated CloudAdapter unit tests.

* Unit test updated

* Changed LogWarning to LogError

* Suggested changes applied

---------

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
@ceciliaavila ceciliaavila mentioned this pull request Feb 17, 2023
Closed
@erquirogasw erquirogasw mentioned this pull request Feb 17, 2023
Closed
@erquirogasw erquirogasw mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can you add a log line for this exception?
4 participants
@erquirogasw @coveralls @BruceHaley @tracyboehrer