Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#6577] Can you add a log line for this exception? (#6587) #4439

Merged

Conversation

erquirogasw
Copy link
Contributor

@erquirogasw erquirogasw commented Feb 24, 2023

Fixes #4437

*Note: this PR depends on PR#4436 and should be merged after.

Description

This PR ports the changes in the PR#6587 to add a log in the process method of the CloudAdapter class to show more information about the exceptions.

Specific Changes

  • Added log to the process method in CloudAdapter.cs.
  • Updated process tests in CloudAdapterTests.cs.

Testing

This image shows the new unit test passing.
eJfjGifR53

@erquirogasw erquirogasw requested a review from a team as a code owner February 24, 2023 21:02
@coveralls
Copy link

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 4926309277

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.863%

Totals Coverage Status
Change from base Build 4916290236: 0.4%
Covered Lines: 20101
Relevant Lines: 22457

💛 - Coveralls

@sw-joelmut sw-joelmut changed the title port: [#6577] Can you add a log line for this exception? (#6587) port: [#4437] Can you add a log line for this exception? (#6587) Feb 27, 2023
@sw-joelmut sw-joelmut changed the title port: [#4437] Can you add a log line for this exception? (#6587) port: [#6577] Can you add a log line for this exception? (#6587) Feb 27, 2023
@tracyboehrer tracyboehrer merged commit 5ee34c0 into main Jun 9, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/log-line-for-UnauthorizedAccessException branch June 9, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: [#6577] Can you add a log line for this exception? (#6587)
5 participants