Support Bot new invoke type: config #6632
Conversation
Pull Request Test Coverage Report for Build 352211
💛 - Coveralls |
yingduyingdu
force-pushed
the
yingdu/invoke
branch
from
7215218 to
89942cf
Compare
| } | ||
|
|
||
| /// <summary> | ||
| /// Override this in a derived class to provide logic for when a config is fetched. |
There was a problem hiding this comment.
minor: should be "config is submitted".
There was a problem hiding this comment.
Updated in the next iteration
| namespace Microsoft.Bot.Schema.Teams | ||
| { | ||
| /// <summary> | ||
| /// Specifies bot config authe, including type and suggestedActions. |
There was a problem hiding this comment.
Updated in the next iteration
yingduyingdu
added
the
Automation: No parity
| /// <summary> | ||
| /// Specifies Invoke response base including response type. | ||
| /// </summary> | ||
| public partial class InvokeResponseBase |
There was a problem hiding this comment.
Is there a reason to name it as InvokeResponseBase, will we have a class of InvokeResponse? I saw we have both classes for task.
There was a problem hiding this comment.
This will align with our class design in the reference repo.
There was a problem hiding this comment.
I can sync up with you offline for this.
yingduyingdu
force-pushed
the
yingdu/invoke
branch
from
89942cf to
c93d725
Compare
| await ((IBot)bot).OnTurnAsync(turnContext); | ||
|
|
||
| // Assert | ||
| //Assert.Equal(2, bot.Record.Count); |
There was a problem hiding this comment.
Updated in the next iteration
| await ((IBot)bot).OnTurnAsync(turnContext); | ||
|
|
||
| // Assert | ||
| //Assert.Equal(2, bot.Record.Count); |
There was a problem hiding this comment.
Updated in the next iteration
yingduyingdu
force-pushed
the
yingdu/invoke
branch
from
b76b871 to
77cb79f
Compare
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
|
The PR will NOT be merged before the Bot config front-end changes rollout to R3. |
Fixes #6634
Description
Support new bot invoke type: config.
Specific Changes
Testing
E2E manual tests against local changes for various config requests and responses.
Unit Tests.