Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Teams config typings #4566

Closed
corinagum opened this issue Nov 13, 2023 · 0 comments · Fixed by #4567 or #4570
Closed

Fix Teams config typings #4566

corinagum opened this issue Nov 13, 2023 · 0 comments · Fixed by #4567 or #4570
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@corinagum
Copy link
Collaborator

Original work item: #4487
Original PR: #4485

  • CacheInfo needs to be optional in ConfigAuth
  • values for responseType and BotConfigAuth's type need to be fixed need to be fixed to 'config' and 'auth', respectively.

This is to bring proper parity to C# version: microsoft/botbuilder-dotnet#6632
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Nov 13, 2023
@corinagum corinagum self-assigned this Nov 13, 2023
@corinagum corinagum mentioned this issue Nov 13, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Nov 14, 2023
@corinagum
fix: #4566 Teams config fetch typings (#4567)
e0e656b 
* Fix Teams config fetch typings

* Update Bot Framework schema

* Compat

---------

Co-authored-by: Corina Gum <>
Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
@corinagum corinagum reopened this Nov 14, 2023
@corinagum corinagum mentioned this issue Nov 14, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Nov 14, 2023
@corinagum
fix: #4566 Refactor Teams config fetch & submit typings (#4570)
60824fe 
* Cleanup types for Teams config fetch & submit

* Compat update

* botbuilder test:compat

---------

Co-authored-by: Corina Gum <>
Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
1 participant
@corinagum