Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #4566 Refactor Teams config fetch & submit typings #4570

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

corinagum
Copy link
Collaborator

@corinagum corinagum commented Nov 14, 2023

Fixes #4566
Related to #4567

Description

Cleanup the typings for Teams config fetch & submit.

Specific Changes

  • Export union type ConfigResponseConfig instead of extending ConfigResponse

@corinagum corinagum requested a review from a team as a code owner November 14, 2023 20:10
@coveralls
Copy link

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build 6869103706

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.635%

Totals Coverage Status
Change from base Build 6858336486: 0.0%
Covered Lines: 20336
Relevant Lines: 22760

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 60824fe into main Nov 14, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the cg/config branch November 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Teams config typings
4 participants