-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for config auth type (fetch & submit) #4485
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Pull Request Test Coverage Report for Build 5338185464
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add unit tests for the new methods using a TestActivityHandler class to implement them and assert the response.
@ceciliaavila could I get a new review please? Addressed your comments. Thanks! |
Historically, developer implemented methods don't have unit tests in this repo, therefore I'll keep as-is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. I still believe unit tests are relevant, mainly because in .NET they were added.
Fixes #4487
Description
Add new Teams invoke types 'config/fetch' and 'config/submit' for supporting Auth & TaskModuleContinue in configuration flow.
Specific Changes
teamsActivityHandler
s for'config/fetch'
and'config/submit'
invoke requestsConfigAuthResponse
,ConfigResponse
, andBotConfigAuthType
for parsing config payloads.Testing
Unit tests added.
=========
Local bot code:
Manual test validation:
'config/fetch' - auth response
'config/fetch' - message
TaskModuleContinue
response'config/submit' card
TaskModuleContinue
response'config/submit' message
TaskModuleContinue
response