feat: Support Single Tenant authentication through BotFramework-Emulator #6769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhontSouth
added
the
Automation: No parity
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll |
Pull Request Test Coverage Report for Build 387278Details
💛 - Coveralls |
tracyboehrer
approved these changes
Apr 10, 2024
tracyboehrer
deleted the
southworks/add/support-to-singletenant-emulator
branch
jevansaks
pushed a commit
to jevansaks/botbuilder-dotnet
that referenced
this pull request
May 10, 2024
…tor (microsoft#6769) * use dynamic Emulator issuer with tenant id to validate identity * use auth constants
|
@JhontSouth This will need to be done in JS too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR includes a dynamic way to validate the access token issuer value depending on the tenant ID used in Emulator.
Specific Changes
Testing
The following image shows the Emulator working with a bot using Single Tenant authentication.
