Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Single Tenant authentication through BotFramework-Emulator #4643

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR includes a dynamic way to validate the access token issuer value depending on the tenant ID used in Emulator.

Specific Changes

  • Added logic to validate the tid and issuer values to allow the Single Tenant authentication

Testing

The following image shows the Emulator working with a bot using Single Tenant authentication.
image

@JhontSouth JhontSouth requested a review from a team as a code owner April 5, 2024 13:54
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8570914029

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 84.484%

Totals Coverage Status
Change from base Build 8558943159: 0.004%
Covered Lines: 20422
Relevant Lines: 22888

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 0b1d958 into main Apr 16, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/support-to-singletenant-emulator branch April 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants