fix: single orchestrator bug and #3841 (#3843)

* fix single orchestrator bug * signature rename in doc * removed unused (error) * minor fixes based on review comments * minor fix based on review comment * add logic for removing "as" * compatibility check fix * remove declaration Co-authored-by: Tien Suwandy <tiens@microsoft.com>
microsoft · Jul 6, 2021 · 1982983 · 1982983
1 parent 290c7e0
commit 1982983
Show file tree

Hide file tree

Showing 3 changed files with 177 additions and 147 deletions.
diff --git a/libraries/botbuilder-ai-orchestrator/etc/botbuilder-ai-orchestrator.api.md b/libraries/botbuilder-ai-orchestrator/etc/botbuilder-ai-orchestrator.api.md
@@ -45,13 +45,13 @@ export class OrchestratorRecognizer extends AdaptiveRecognizer implements Orches
     // (undocumented)
     static $kind: string;
     // Warning: (ae-forgotten-export) The symbol "LabelResolver" needs to be exported by the entry point index.d.ts
-    constructor(modelFolder?: string, snapshotFile?: string, resolver?: LabelResolver);
+    constructor(modelFolder?: string, snapshotFile?: string, resolverExternal?: LabelResolver);
     readonly chooseIntent = "ChooseIntent";
     detectAmbiguousIntents: BoolExpression;
     disambiguationScoreThreshold: NumberExpression;
     readonly entityProperty = "entityResult";
-    externalEntityRecognizer: Recognizer;
-    protected fillRecognizerResultTelemetryProperties(recognizerResult: RecognizerResult, telemetryProperties: Record<string, string>, dialogContext?: DialogContext): Record<string, string>;
+    externalEntityRecognizer?: Recognizer;
+    protected fillRecognizerResultTelemetryProperties(recognizerResult: RecognizerResult, telemetryProperties?: Record<string, string>, dialogContext?: DialogContext): Record<string, string>;
     // (undocumented)
     getConverter(property: keyof OrchestratorRecognizerConfiguration): Converter | ConverterFactory;
     modelFolder: StringExpression;