Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single orchestrator bug and #3841 #3843

Merged

Conversation

hcyang
Copy link
Contributor

@hcyang hcyang commented Jul 2, 2021

Fixes #3841

Description

Current OrchestratorRecognizer implement can only uses one Ochestrator object.
This fix is a parallel of the the fix (microsoft/botbuilder-dotnet#5749) for the dotnet issue microsoft/botbuilder-dotnet#5750

Specific Changes

Testing

@hcyang hcyang added bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker Area: AI-Orchestrator The issue is related to Orchestrator labels Jul 2, 2021
@hcyang hcyang added this to the R15 milestone Jul 2, 2021
@hcyang hcyang requested review from daveta and tsuwandy July 2, 2021 06:11
@hcyang hcyang self-assigned this Jul 2, 2021
@hcyang hcyang requested a review from a team as a code owner July 2, 2021 06:11
@hcyang hcyang changed the title fix single orchestrator bug fix: single orchestrator bug and #3841 Jul 2, 2021
@coveralls
Copy link

coveralls commented Jul 2, 2021

Pull Request Test Coverage Report for Build 1005566996

  • 54 of 77 (70.13%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 84.341%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 54 77 70.13%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 2 67.29%
Totals Coverage Status
Change from base Build 994998196: -0.02%
Covered Lines: 19671
Relevant Lines: 22128

💛 - Coveralls

@hcyang hcyang merged commit 1982983 into main Jul 6, 2021
@hcyang hcyang deleted the hunyang/Orchestrator_BotBuilderDotNetFixSingleOrchestratorBug branch July 6, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AI-Orchestrator The issue is related to Orchestrator bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When entity model is available, OrchestratorRecognizer failed to load it
4 participants