-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: single orchestrator bug and #3841 #3843
Merged
hcyang
merged 12 commits into
main
from
hunyang/Orchestrator_BotBuilderDotNetFixSingleOrchestratorBug
Jul 6, 2021
Merged
fix: single orchestrator bug and #3841 #3843
hcyang
merged 12 commits into
main
from
hunyang/Orchestrator_BotBuilderDotNetFixSingleOrchestratorBug
Jul 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcyang
added
bug
Indicates an unexpected problem or an unintended behavior.
P0
Must Fix. Release-blocker
Area: AI-Orchestrator
The issue is related to Orchestrator
labels
Jul 2, 2021
hcyang
changed the title
fix single orchestrator bug
fix: single orchestrator bug and #3841
Jul 2, 2021
Pull Request Test Coverage Report for Build 1005566996
💛 - Coveralls |
tsuwandy
reviewed
Jul 2, 2021
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
tsuwandy
reviewed
Jul 2, 2021
tsuwandy
reviewed
Jul 2, 2021
tsuwandy
reviewed
Jul 2, 2021
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts
Outdated
Show resolved
Hide resolved
…leOrchestratorBug
…torBug' of https://github.com/Microsoft/botbuilder-js into hunyang/Orchestrator_BotBuilderDotNetFixSingleOrchestratorBug
…leOrchestratorBug
tsuwandy
approved these changes
Jul 2, 2021
…leOrchestratorBug
joshgummersall
approved these changes
Jul 6, 2021
hcyang
deleted the
hunyang/Orchestrator_BotBuilderDotNetFixSingleOrchestratorBug
branch
July 6, 2021 19:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: AI-Orchestrator
The issue is related to Orchestrator
bug
Indicates an unexpected problem or an unintended behavior.
P0
Must Fix. Release-blocker
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3841
Description
Current OrchestratorRecognizer implement can only uses one Ochestrator object.
This fix is a parallel of the the fix (microsoft/botbuilder-dotnet#5749) for the dotnet issue microsoft/botbuilder-dotnet#5750
Specific Changes
Testing