Updated Bool function to evaluate 'false' (#4320)

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
microsoft · Sep 9, 2022 · a7b90f3 · a7b90f3
1 parent 403b4f7
commit a7b90f3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/libraries/adaptive-expressions/src/builtinFunctions/bool.ts b/libraries/adaptive-expressions/src/builtinFunctions/bool.ts
@@ -30,6 +30,10 @@ export class Bool extends ComparisonEvaluator {
             return args[0] !== 0;
         }
 
+        if (/false/i.test(args[0])) {
+            return false;
+        }
+
         return InternalFunctionUtils.isLogicTrue(args[0]);
     }
 }
diff --git a/libraries/adaptive-expressions/tests/expressionParser.test.js b/libraries/adaptive-expressions/tests/expressionParser.test.js
@@ -419,7 +419,8 @@ const testCases = [
             ['bool(0)', false],
             ['bool(null)', false],
             ['bool(hello * 5)', false],
-            ["bool('false')", true], // we make it true, because it is not empty
+            ["bool('false')", false],
+            ["bool('true')", true],
             ["bool('hi')", true],
             ['[1,2,3]', [1, 2, 3]],
             ['[1,2,3, [4,5]]', [1, 2, 3, [4, 5]]],