Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BotFrameworkAdapter.isStreamingConnectionOpen should use a nullish check #3414

Closed
stevengum opened this issue Mar 19, 2021 · 0 comments · Fixed by #3428
Closed

BotFrameworkAdapter.isStreamingConnectionOpen should use a nullish check #3414

stevengum opened this issue Mar 19, 2021 · 0 comments · Fixed by #3428
Assignees
@stevengum
Labels
Area: Streaming Issues related to streaming support bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker
Milestone
R13

Comments

@stevengum
Copy link
Member

Otherwise without a streamingServer on the adapter, the code explodes saying it can’t find isConnected of undefined
@stevengum stevengum added bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker Area: Streaming Issues related to streaming support labels Mar 19, 2021
@stevengum stevengum added this to the R13 milestone Mar 19, 2021
@stevengum stevengum self-assigned this Mar 19, 2021
stevengum added a commit that referenced this issue Mar 23, 2021
@stevengum
add nullish coalescing operators for #3414
e6dd31a
@stevengum stevengum mentioned this issue Mar 23, 2021
Merged
stevengum added a commit that referenced this issue Mar 24, 2021
@stevengum
fixes: BotFrameworkAdapter.isStreamingConnectionOpen & retrieving Bot…
ec062e9 
…TelemetryClient from TurnContext.turnState (#3428)

* add nullish coalescing operators for #3414

* add BotTelemetryClientKey for #3415
* add botframework-connector as dependency to botbuilder-dialogs
* add get<T = any>() for #3400
* remove skillsHelpers from botbuilder-dialogs

* clean up refs to skillsHelper in tests/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
Area: Streaming Issues related to streaming support bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker
Projects
None yet
Milestone
R13
1 participant
@stevengum