Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes: BotFrameworkAdapter.isStreamingConnectionOpen & retrieving BotTelemetryClient from TurnContext.turnState #3428

Merged
merged 3 commits into from
Mar 24, 2021
Merged

fixes: BotFrameworkAdapter.isStreamingConnectionOpen & retrieving BotTelemetryClient from TurnContext.turnState #3428

merged 3 commits into from
Mar 24, 2021

Conversation

stevengum
Copy link
Member

Fixes #3414
Fixes #3415
Fixes #3400

@stevengum
add nullish coalescing operators for #3414
e6dd31a
@stevengum
add BotTelemetryClientKey for #3415
6dc17d1 
* add botframework-connector as dependency to botbuilder-dialogs
* add get<T = any>() for #3400
* remove skillsHelpers from botbuilder-dialogs
@stevengum stevengum requested review from a team as code owners March 23, 2021 23:37
@stevengum stevengum requested a review from chrimc62 March 23, 2021 23:37
joshgummersall
joshgummersall approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me- I'm a little nervous about essentially unchecked type casting with get, but we are where we are 😄

@coveralls
Copy link

coveralls commented Mar 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 681374046

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 32 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 85.109%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/turnContextStateCollection.ts 2 79.31%
libraries/botbuilder-dialogs/src/recognizer.ts 6 61.29%
libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts 24 75.79%
Totals Coverage Status
Change from base Build 680203276: -0.01%
Covered Lines: 18773
Relevant Lines: 21006
💛 - Coveralls

@stevengum stevengum merged commit ec062e9 into main Mar 24, 2021
@stevengum stevengum deleted the stgum/3414/3415 branch March 24, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stevengum @coveralls @joshgummersall