Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: pass through StateConfiguration in DialogManager (#5440) #3538

Closed
github-actions bot opened this issue Apr 6, 2021 · 2 comments · Fixed by #3540
Closed

port: pass through StateConfiguration in DialogManager (#5440) #3538

github-actions bot opened this issue Apr 6, 2021 · 2 comments · Fixed by #3540
Assignees
@joshgummersall
Labels
Area: Adaptive The issue is related to Adaptive dialogs parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Milestone
R13

Comments

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

The changes in pass through StateConfiguration in DialogManager (#5440) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5431

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Apr 6, 2021
@joshgummersall
Copy link
Contributor

Handle as part of #3373

@joshgummersall
Copy link
Contributor

Actually, should come now.

@joshgummersall joshgummersall reopened this Apr 6, 2021
@joshgummersall joshgummersall self-assigned this Apr 6, 2021
joshgummersall pushed a commit that referenced this issue Apr 7, 2021
port: pass through dialog state manager config
89c8294 
Fixes #3538
@joshgummersall joshgummersall mentioned this issue Apr 7, 2021
Merged
joshgummersall pushed a commit that referenced this issue Apr 7, 2021
port: pass through dialog state manager config
54d0525 
Fixes #3538
@joshgummersall joshgummersall added Area: Adaptive The issue is related to Adaptive dialogs Size: S The issue is simple and well understood, it will take a day or less to complete and removed ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 7, 2021
@joshgummersall joshgummersall added this to the R13 milestone Apr 7, 2021
joshgummersall added a commit that referenced this issue Apr 7, 2021
@joshgummersall
port: several parity issues (#3540)
023e244 
* port: pass through dialog state manager config

Fixes #3538

* port: turn memory scope exclude from snapshot

Fixes #3539

* port: update default property path for oauth input

Fixes #3536

* port: update http request default result property

Fixes #3537
joshgummersall added a commit that referenced this issue Apr 7, 2021
@joshgummersall
port: several parity issues (#3540)
77992ee 
* port: pass through dialog state manager config

Fixes #3538

* port: turn memory scope exclude from snapshot

Fixes #3539

* port: update default property path for oauth input

Fixes #3536

* port: update http request default result property

Fixes #3537
@joshgummersall joshgummersall mentioned this issue Apr 7, 2021
Merged
joshgummersall added a commit that referenced this issue Apr 7, 2021
@joshgummersall
port: several parity issues (#3540) (#3542)
4dddf77 
* port: pass through dialog state manager config

Fixes #3538

* port: turn memory scope exclude from snapshot

Fixes #3539

* port: update default property path for oauth input

Fixes #3536

* port: update http request default result property

Fixes #3537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

Labels
Area: Adaptive The issue is related to Adaptive dialogs parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Milestone
R13
Development

Successfully merging a pull request may close this issue.

port: several parity issues microsoft/botbuilder-js
1 participant
@joshgummersall